[commit: ghc] ghc-8.6: Do not imply NoStarIsType by TypeOperators/TypeInType (bb5aa61)

[git at git.haskell.org]

Repository : ssh://git@git.haskell.org/ghc

On branch  : ghc-8.6
Link       : http://ghc.haskell.org/trac/ghc/changeset/bb5aa616905727a7c73bc323164d6812e093c2dc/ghc

>---------------------------------------------------------------

commit bb5aa616905727a7c73bc323164d6812e093c2dc
Author: Vladislav Zavialov <vlad.z.4096 at gmail.com>
Date:   Mon Jul 16 18:46:52 2018 -0400

    Do not imply NoStarIsType by TypeOperators/TypeInType
    
    Implementation of the "Embrace TypeInType" proposal was done according
    to the spec, which specified that TypeOperators must imply NoStarIsType.
    This implication was meant to prevent breakage and to be removed in 2
    releases.  However, compiling head.hackage has shown that this
    implication only magnified the breakage, so there is no reason to have
    it in the first place.
    
    To remain in compliance with the three-release policy, we add a
    workaround to define the (*) type operator even when -XStarIsType is on.
    
    Test Plan: ./validate
    
    Reviewers: bgamari, RyanGlScott, goldfire, phadej, hvr
    
    Reviewed By: bgamari, RyanGlScott
    
    Subscribers: harpocrates, rwbarton, thomie, carter
    
    Differential Revision: https://phabricator.haskell.org/D4865
    
    (cherry picked from commit 65c186f0fdde95fd7c63ab9bd9b33a0213dba7d1)


>---------------------------------------------------------------

bb5aa616905727a7c73bc323164d6812e093c2dc
 compiler/basicTypes/RdrName.hs                     | 23 ++++++---------
 compiler/main/DynFlags.hs                          | 15 ++++------
 compiler/parser/Lexer.x                            |  5 ----
 compiler/parser/RdrHsSyn.hs                        | 20 +++++++++++--
 compiler/rename/RnEnv.hs                           |  3 +-
 docs/users_guide/8.6.1-notes.rst                   |  3 +-
 docs/users_guide/glasgow_exts.rst                  |  8 ++----
 docs/users_guide/using-warnings.rst                | 31 ++++++++++++++++++++
 libraries/base/GHC/TypeNats.hs                     |  1 +
 testsuite/tests/dependent/ghci/T14238.stdout       |  2 +-
 .../partial-sigs/should_compile/T15039b.stderr     | 33 +++++++++-------------
 .../partial-sigs/should_compile/T15039d.stderr     | 33 +++++++++-------------
 testsuite/tests/polykinds/T10134.hs                |  6 ++--
 testsuite/tests/th/TH_unresolvedInfix.hs           |  1 +
 testsuite/tests/th/TH_unresolvedInfix_Lib.hs       |  1 +
 .../typecheck/should_compile/TcTypeNatSimple.hs    | 16 +++++------
 .../should_compile/type_in_type_hole_fits.hs       |  4 +--
 .../typecheck/should_run/TcTypeNatSimpleRun.hs     |  6 ++--
 .../tests/warnings/should_compile/StarBinder.hs    |  5 ++++
 .../warnings/should_compile/StarBinder.stderr      | 10 +++++++
 testsuite/tests/warnings/should_compile/all.T      |  2 ++
 21 files changed, 132 insertions(+), 96 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc bb5aa616905727a7c73bc323164d6812e093c2dc