[commit: ghc] master: Remove Hoopl.Unique (bd58e29)

git at git.haskell.org git at git.haskell.org
Fri Jan 26 19:41:11 UTC 2018


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/bd58e290a4dc3beed2e63fbe549aadbdf17ae437/ghc

>---------------------------------------------------------------

commit bd58e290a4dc3beed2e63fbe549aadbdf17ae437
Author: Michal Terepeta <michal.terepeta at gmail.com>
Date:   Fri Jan 26 13:09:29 2018 -0500

    Remove Hoopl.Unique
    
    Reasons to remove:
    - It's confusing - we already have a widely used `Unique` module in
      `basicTypes/` that defines a newtype called `Unique`
    - `Hoopl.Unique` is not actually used much
    
    I've also moved the `Unique{Map,Set}` from `Hoopl.Unique` to
    `Hoopl.Collections` to keep things together. But that module is also a
    bit funny - it defines two type-classes that have only one instance
    each. So we should probably either remove them or use them more
    widely... In any case, that will be a separate change.
    
    Signed-off-by: Michal Terepeta <michal.terepeta at gmail.com>
    
    Test Plan: ./validate
    
    Reviewers: bgamari, simonmar
    
    Reviewed By: bgamari
    
    Subscribers: kavon, rwbarton, thomie, carter
    
    Differential Revision: https://phabricator.haskell.org/D4331


>---------------------------------------------------------------

bd58e290a4dc3beed2e63fbe549aadbdf17ae437
 compiler/cmm/BlockId.hs           |  5 +--
 compiler/cmm/Hoopl/Collections.hs | 71 ++++++++++++++++++++++++++++++
 compiler/cmm/Hoopl/Label.hs       | 25 +++++------
 compiler/cmm/Hoopl/Unique.hs      | 93 ---------------------------------------
 compiler/ghc.cabal.in             |  1 -
 5 files changed, 85 insertions(+), 110 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc bd58e290a4dc3beed2e63fbe549aadbdf17ae437


More information about the ghc-commits mailing list