[commit: ghc] wip/14691: Remove Note [Memoising typeOf] (9531e14)

git at git.haskell.org git at git.haskell.org
Sun Jan 21 14:14:41 UTC 2018


Repository : ssh://git@git.haskell.org/ghc

On branch  : wip/14691
Link       : http://ghc.haskell.org/trac/ghc/changeset/9531e1479d21017ccb6d3437fb325e934c968d3f/ghc

>---------------------------------------------------------------

commit 9531e1479d21017ccb6d3437fb325e934c968d3f
Author: Joachim Breitner <mail at joachim-breitner.de>
Date:   Sun Jan 21 09:04:13 2018 -0500

    Remove Note [Memoising typeOf]
    
    its reference (and presumably relevance) was removed in 8fa4bf9.


>---------------------------------------------------------------

9531e1479d21017ccb6d3437fb325e934c968d3f
 compiler/deSugar/DsBinds.hs | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/compiler/deSugar/DsBinds.hs b/compiler/deSugar/DsBinds.hs
index b87d5ad..5974a60 100644
--- a/compiler/deSugar/DsBinds.hs
+++ b/compiler/deSugar/DsBinds.hs
@@ -1309,12 +1309,3 @@ tyConRep tc
   = pprPanic "tyConRep" (ppr tc)
 -}
 
-{- Note [Memoising typeOf]
-~~~~~~~~~~~~~~~~~~~~~~~~~~
-See #3245, #9203
-
-IMPORTANT: we don't want to recalculate the TypeRep once per call with
-the proxy argument.  This is what went wrong in #3245 and #9203. So we
-help GHC by manually keeping the 'rep' *outside* the lambda.
--}
-



More information about the ghc-commits mailing list