[commit: ghc] master: Support LIBRARY_PATH and LD_LIBRARY_PATH in rts (87917a5)

git at git.haskell.org git at git.haskell.org
Mon Jan 15 19:22:39 UTC 2018


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/87917a594f37b70810013168a5df64d630620724/ghc

>---------------------------------------------------------------

commit 87917a594f37b70810013168a5df64d630620724
Author: Ben Gamari <ben at smart-cactus.org>
Date:   Mon Jan 15 12:40:22 2018 -0500

    Support LIBRARY_PATH and LD_LIBRARY_PATH in rts
    
    `LIBRARY_PATH` is used to find libraries and other link artifacts while
    `LD_LIBRARY_PATH` is used to find shared libraries by the loader.
    
    Due to an implementation detail on Windows, using `LIBRARY_PATH` will
    automatically add the path of any library found to the loader's path.
    
    So in that case `LD_LIBRARY_PATH` won't be needed.
    
    Test Plan:
    ./validate along with T14611 which has been made Windows only
    due to linux using the system linker/loader by default. So I feel a
    testcase there is unwarranted as the support is indirect via glibc.
    
    Reviewers: hvr, bgamari, erikd, simonmar, RyanGlScott
    
    Reviewed By: RyanGlScott
    
    Subscribers: RyanGlScott, rwbarton, thomie, carter
    
    GHC Trac Issues: #14611
    
    Differential Revision: https://phabricator.haskell.org/D4275


>---------------------------------------------------------------

87917a594f37b70810013168a5df64d630620724
 compiler/ghci/Linker.hs                            | 37 ++++++++++++++++++----
 docs/users_guide/8.6.1-notes.rst                   |  7 ++--
 docs/users_guide/ghci.rst                          | 21 +++++++++---
 testsuite/tests/rts/{T12771 => T14611}/Makefile    |  4 +--
 .../bkprun02.stdout => rts/T14611/T14611.stdout}   |  0
 testsuite/tests/rts/{T12771 => T14611}/all.T       |  4 +--
 testsuite/tests/rts/{T12771 => T14611}/foo.c       |  0
 testsuite/tests/rts/{T12771 => T14611}/foo_dll.c   |  0
 testsuite/tests/rts/{T12771 => T14611}/main.hs     |  0
 9 files changed, 56 insertions(+), 17 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 87917a594f37b70810013168a5df64d630620724


More information about the ghc-commits mailing list