[commit: ghc] master: CircleCI: Fix check for git push retry limit. (95fbf87)

git at git.haskell.org git at git.haskell.org
Fri Dec 21 21:56:43 UTC 2018


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/95fbf87886c4a3c076d71d37e1306f64e0e98b57/ghc

>---------------------------------------------------------------

commit 95fbf87886c4a3c076d71d37e1306f64e0e98b57
Author: David Eichmann <EichmannD at gmail.com>
Date:   Wed Dec 19 11:46:13 2018 -0500

    CircleCI: Fix check for git push retry limit.
    
    Test Plan: Observe CircleCI
    
    Reviewers: bgamari
    
    Reviewed By: bgamari
    
    Subscribers: rwbarton, carter
    
    Differential Revision: https://phabricator.haskell.org/D5464


>---------------------------------------------------------------

95fbf87886c4a3c076d71d37e1306f64e0e98b57
 .circleci/push-test-metrics.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.circleci/push-test-metrics.sh b/.circleci/push-test-metrics.sh
index d8222b7..e383a4c 100755
--- a/.circleci/push-test-metrics.sh
+++ b/.circleci/push-test-metrics.sh
@@ -42,9 +42,9 @@ function reset_append_note_push {
 # Push the metrics file as a git note. This may fail if another task pushes a note first. In that case
 # the latest note is fetched and appended.
 MAX_RETRY=20
-until reset_append_note_push || [ MAX_RETRY = 0 ]
+until reset_append_note_push || [ $MAX_RETRY -le 0 ]
 do
   ((MAX_RETRY--))
   echo ""
-  echo "Failed to push git notes. Fetching, appending, and retrying..."
+  echo "Failed to push git notes. Fetching, appending, and retrying... $MAX_RETRY retries left."
 done



More information about the ghc-commits mailing list