[commit: ghc] master: Use https links in user-facing startup and error messages (a1c0b70)

git at git.haskell.org git at git.haskell.org
Sat Dec 15 00:49:47 UTC 2018


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/a1c0b70638949a73bbd404c11797f2edf28f5965/ghc

>---------------------------------------------------------------

commit a1c0b70638949a73bbd404c11797f2edf28f5965
Author: Ben Gamari <ben at smart-cactus.org>
Date:   Fri Dec 14 11:10:56 2018 -0500

    Use https links in user-facing startup and error messages
    
    I consider myself lucky that in my circle of friends, `http` urls (as
    opposed to `https` urls) are frowned upon in that we generally
    apologize in the rase cases that we share an `http` url.
    
    This pull request changes `http` links into their `https` analogues in
    the following places:
    
    * In the GHCI startup message (and parts of the User's Guide, where
    there are verbatim transcripts of GHCi sessions).
    * In a couple of error messages, asking the user to report a bug.
    
    (I also took the liberty to change a single space before the reportabug
    url into two spaces, harmonizing this occurence with the others.)
    
    I'm not trying to start a war. I just had a moment to spare and felt
    like preparing this diff. Merge or don't merge as you wish!
    
    Reviewers: bgamari, erikd, simonmar
    
    Subscribers: goldfire, rwbarton, carter
    
    Differential Revision: https://phabricator.haskell.org/D5450


>---------------------------------------------------------------

a1c0b70638949a73bbd404c11797f2edf28f5965
 compiler/typecheck/TcTyClsDecls.hs | 2 +-
 compiler/utils/Panic.hs            | 2 +-
 docs/users_guide/ghci.rst          | 4 ++--
 ghc/GHCi/UI.hs                     | 2 +-
 rts/RtsMessages.c                  | 2 +-
 5 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/compiler/typecheck/TcTyClsDecls.hs b/compiler/typecheck/TcTyClsDecls.hs
index cc9779a..71899a1 100644
--- a/compiler/typecheck/TcTyClsDecls.hs
+++ b/compiler/typecheck/TcTyClsDecls.hs
@@ -3609,7 +3609,7 @@ checkValidRoles tc
     report_error doc
       = addErrTc $ vcat [text "Internal error in role inference:",
                          doc,
-                         text "Please report this as a GHC bug: http://www.haskell.org/ghc/reportabug"]
+                         text "Please report this as a GHC bug:  https://www.haskell.org/ghc/reportabug"]
 
 {-
 ************************************************************************
diff --git a/compiler/utils/Panic.hs b/compiler/utils/Panic.hs
index 03f095b..4f0f3b1 100644
--- a/compiler/utils/Panic.hs
+++ b/compiler/utils/Panic.hs
@@ -168,7 +168,7 @@ showGhcException exception
         showString "panic! (the 'impossible' happened)\n"
       . showString ("  (GHC version " ++ cProjectVersion ++ " for " ++ TargetPlatform_NAME ++ "):\n\t")
       . s . showString "\n\n"
-      . showString "Please report this as a GHC bug:  http://www.haskell.org/ghc/reportabug\n"
+      . showString "Please report this as a GHC bug:  https://www.haskell.org/ghc/reportabug\n"
 
 
 throwGhcException :: GhcException -> a
diff --git a/docs/users_guide/ghci.rst b/docs/users_guide/ghci.rst
index 49a96ca..f468e80 100644
--- a/docs/users_guide/ghci.rst
+++ b/docs/users_guide/ghci.rst
@@ -37,7 +37,7 @@ command ``ghci``:
 .. code-block:: none
 
     $ ghci
-    GHCi, version 8.y.z: http://www.haskell.org/ghc/  :? for help
+    GHCi, version 8.y.z: https://www.haskell.org/ghc/  :? for help
     Prelude>
 
 There may be a short pause while GHCi loads the prelude and standard
@@ -2052,7 +2052,7 @@ by using the :ghc-flag:`-package ⟨pkg⟩` flag:
 .. code-block:: none
 
     $ ghci -package readline
-    GHCi, version 8.y.z: http://www.haskell.org/ghc/  :? for help
+    GHCi, version 8.y.z: https://www.haskell.org/ghc/  :? for help
     Loading package base ... linking ... done.
     Loading package readline-1.0 ... linking ... done.
     Prelude>
diff --git a/ghc/GHCi/UI.hs b/ghc/GHCi/UI.hs
index ae8ba02..13275f8 100644
--- a/ghc/GHCi/UI.hs
+++ b/ghc/GHCi/UI.hs
@@ -162,7 +162,7 @@ defaultGhciSettings =
 
 ghciWelcomeMsg :: String
 ghciWelcomeMsg = "GHCi, version " ++ cProjectVersion ++
-                 ": http://www.haskell.org/ghc/  :? for help"
+                 ": https://www.haskell.org/ghc/  :? for help"
 
 ghciCommands :: [Command]
 ghciCommands = map mkCmd [
diff --git a/rts/RtsMessages.c b/rts/RtsMessages.c
index 053805e..a90962e 100644
--- a/rts/RtsMessages.c
+++ b/rts/RtsMessages.c
@@ -172,7 +172,7 @@ rtsFatalInternalErrorFn(const char *s, va_list ap)
 #endif
      fprintf(stderr, "\n");
      fprintf(stderr, "    (GHC version %s for %s)\n", ProjectVersion, xstr(HostPlatform_TYPE));
-     fprintf(stderr, "    Please report this as a GHC bug:  http://www.haskell.org/ghc/reportabug\n");
+     fprintf(stderr, "    Please report this as a GHC bug:  https://www.haskell.org/ghc/reportabug\n");
      fflush(stderr);
   }
 #if defined(mingw32_HOST_OS)



More information about the ghc-commits mailing list