[commit: ghc] master: function-section: enable on windows (23774c9)

git at git.haskell.org git at git.haskell.org
Tue Aug 21 22:56:46 UTC 2018


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/23774c98f1368b41515cbd5223b87ea6dbf644e1/ghc

>---------------------------------------------------------------

commit 23774c98f1368b41515cbd5223b87ea6dbf644e1
Author: Tamar Christina <tamar at zhox.com>
Date:   Tue Aug 21 12:13:06 2018 -0400

    function-section: enable on windows
    
    gc-sections was onced observed to be slow on Windows, which is the only
    reason it's not enabled yet.  However, it seems to be better now.
    
    Test Plan: ./validate
    
    Reviewers: bgamari
    
    Reviewed By: bgamari
    
    Subscribers: rwbarton, thomie, carter
    
    GHC Trac Issues: #15051
    
    Differential Revision: https://phabricator.haskell.org/D4916


>---------------------------------------------------------------

23774c98f1368b41515cbd5223b87ea6dbf644e1
 mk/config.mk.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mk/config.mk.in b/mk/config.mk.in
index 1105012..e4a79a1 100644
--- a/mk/config.mk.in
+++ b/mk/config.mk.in
@@ -365,7 +365,7 @@ SplitObjs = $(if $(and $(filter YES,$(SupportsSplitObjs)),\
 # This is not supported on Darwin (where you can use subsections-via-symbols
 # instead) and Windows is disabled until we figure the linking performance
 # issues related to BFD out. (See #11445, #12913 and related tickets.)
-OsSupportsSplitSections=$(if $(filter $(TargetOS_CPP),mingw32 darwin),NO,YES)
+OsSupportsSplitSections=$(if $(filter $(TargetOS_CPP),darwin),NO,YES)
 SupportsSplitSections=$(if $(and $(filter YES,$(OsSupportsSplitSections)),\
                                    $(filter YES,$(LdIsGNULd))),YES,NO)
 SplitSections ?= $(SupportsSplitSections)



More information about the ghc-commits mailing list