[commit: ghc] master: Add a solveEqualities to tcClassDecl1 (43b08cf)

git at git.haskell.org git at git.haskell.org
Tue Aug 21 16:12:22 UTC 2018


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/43b08cfbac5ce7ad6fc245651329094896de06e0/ghc

>---------------------------------------------------------------

commit 43b08cfbac5ce7ad6fc245651329094896de06e0
Author: Simon Peyton Jones <simonpj at microsoft.com>
Date:   Tue Aug 21 15:57:56 2018 +0100

    Add a solveEqualities to tcClassDecl1
    
    Trac #15505 showed that, when we have a type error, we
    could have an unfilled-in coercion hole.  We don't want an
    assertion error in that case.
    
    The underlying cause is that tcClassDecl1 should call
    solveEqualities to fully solve all top-level equalities
    (or fail in the attempt).
    
    I also refactored the ClassDecl case for tcTyClDecl1 into
    a new function tcClassDecl1.  That makes it symmetrical
    with the others.


>---------------------------------------------------------------

43b08cfbac5ce7ad6fc245651329094896de06e0
 compiler/deSugar/DsMeta.hs         |   4 +-
 compiler/hsSyn/Convert.hs          |   2 +-
 compiler/hsSyn/HsDecls.hs          |   7 +-
 compiler/parser/RdrHsSyn.hs        |   3 +-
 compiler/rename/RnSource.hs        |   3 +-
 compiler/typecheck/TcHsType.hs     |  10 +-
 compiler/typecheck/TcTyClsDecls.hs | 395 +++++++++++++++++++------------------
 7 files changed, 222 insertions(+), 202 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 43b08cfbac5ce7ad6fc245651329094896de06e0


More information about the ghc-commits mailing list