[commit: ghc] master: Revert "Don't inline functions with RULES too early" (1df50a0)

[git at git.haskell.org]

Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/1df50a0f61f320428f2e6dd07b3c9ce49c4acd31/ghc

>---------------------------------------------------------------

commit 1df50a0f61f320428f2e6dd07b3c9ce49c4acd31
Author: Ben Gamari <ben at smart-cactus.org>
Date:   Wed Aug 1 06:42:19 2018 -0400

    Revert "Don't inline functions with RULES too early"
    
    This commit causes significant performance regressions:
    ```
    bytes allocated value is too high:
        Expected    T9872d(normal) bytes allocated: 578498120 +/-5%
        Lower bound T9872d(normal) bytes allocated: 549573214
        Upper bound T9872d(normal) bytes allocated: 607423026
        Actual      T9872d(normal) bytes allocated: 677179968
        Deviation   T9872d(normal) bytes allocated:      17.1 %
    bytes allocated value is too high:
        Expected    T9872c(normal) bytes allocated: 3096670112 +/-5%
        Lower bound T9872c(normal) bytes allocated: 2941836606
        Upper bound T9872c(normal) bytes allocated: 3251503618
        Actual      T9872c(normal) bytes allocated: 3601872536
        Deviation   T9872c(normal) bytes allocated:       16.3 %
    bytes allocated value is too high:
        Expected    T9872b(normal) bytes allocated: 3730686224 +/-5%
        Lower bound T9872b(normal) bytes allocated: 3544151912
        Upper bound T9872b(normal) bytes allocated: 3917220536
        Actual      T9872b(normal) bytes allocated: 4374298272
        Deviation   T9872b(normal) bytes allocated:       17.3 %
    bytes allocated value is too high:
        Expected    T9872a(normal) bytes allocated: 2729927408 +/-5%
        Lower bound T9872a(normal) bytes allocated: 2593431037
        Upper bound T9872a(normal) bytes allocated: 2866423779
        Actual      T9872a(normal) bytes allocated: 3225788896
        Deviation   T9872a(normal) bytes allocated:       18.2 %
    ```
    It's not clear that this was intentional so I'm going to revert for now.
    
    This reverts commit 2110738b280543698407924a16ac92b6d804dc36.


>---------------------------------------------------------------

1df50a0f61f320428f2e6dd07b3c9ce49c4acd31
 compiler/basicTypes/BasicTypes.hs                  | 10 -----
 compiler/basicTypes/MkId.hs                        |  2 +-
 compiler/specialise/Rules.hs                       | 49 ++++------------------
 compiler/stranal/WorkWrap.hs                       |  4 +-
 testsuite/tests/simplCore/should_compile/T15445.hs |  8 ----
 .../tests/simplCore/should_compile/T15445.stderr   | 13 ------
 .../tests/simplCore/should_compile/T15445a.hs      | 10 -----
 testsuite/tests/simplCore/should_compile/all.T     |  1 -
 8 files changed, 10 insertions(+), 87 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 1df50a0f61f320428f2e6dd07b3c9ce49c4acd31