[commit: ghc] master: Some cleanup of the Exitification code (b14c037)

git at git.haskell.org git at git.haskell.org
Mon Apr 9 15:25:23 UTC 2018


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/b14c03737574895718eed786a60dfdfd42ab49ce/ghc

>---------------------------------------------------------------

commit b14c03737574895718eed786a60dfdfd42ab49ce
Author: Joachim Breitner <mail at joachim-breitner.de>
Date:   Fri Apr 6 17:26:45 2018 -0400

    Some cleanup of the Exitification code
    
    based on a thorough review by Simon in comments
    https://ghc.haskell.org/trac/ghc/ticket/14152#comment:33
    through 37.
    
    The changes are:
    
     * `isExitJoinId` is moved to `SimplUtils`, because
       it is only valid when occurrence information is up-to-date.
     * Abstracted variables are properly sorted using `sortQuantVars`
     * Exitification does not set occ info.
    
     And then minor quibles to notes and avoiding some unhelpful shadowing
     of local names.
    
     Differential Revision: https://phabricator.haskell.org/D4576


>---------------------------------------------------------------

b14c03737574895718eed786a60dfdfd42ab49ce
 compiler/basicTypes/Id.hs        |  6 +-----
 compiler/simplCore/Exitify.hs    | 45 ++++++++++++++++++++++------------------
 compiler/simplCore/SimplUtils.hs | 12 ++++++++++-
 3 files changed, 37 insertions(+), 26 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc b14c03737574895718eed786a60dfdfd42ab49ce


More information about the ghc-commits mailing list