[commit: ghc] master: Renamer now preserves location for IEThingWith list items (9498c50)
git at git.haskell.org
git at git.haskell.org
Fri Sep 15 19:37:43 UTC 2017
Repository : ssh://git@git.haskell.org/ghc
On branch : master
Link : http://ghc.haskell.org/trac/ghc/changeset/9498c50ef5af2680305e0aaea6f32439cacc3da0/ghc
>---------------------------------------------------------------
commit 9498c50ef5af2680305e0aaea6f32439cacc3da0
Author: Alan Zimmerman <alan.zimm at gmail.com>
Date: Fri Sep 15 14:35:51 2017 -0400
Renamer now preserves location for IEThingWith list items
Prior to this, in the RenamedSource for
module Renaming.RenameInExportedType
(
MyType (NT)
) where
data MyType = MT Int | NT
The (NT) was given the location of MyType earlier on the line in the
export list.
Also the location was discarded for any field labels, and replaced with
a `noLoc`.
Test Plan: ./validate
Reviewers: bgamari, austin
Reviewed By: bgamari
Subscribers: rwbarton, thomie
GHC Trac Issues: #14189
Differential Revision: https://phabricator.haskell.org/D3968
>---------------------------------------------------------------
9498c50ef5af2680305e0aaea6f32439cacc3da0
compiler/typecheck/TcRnExports.hs | 37 +++---
testsuite/tests/parser/should_compile/T14189.hs | 6 +
.../tests/parser/should_compile/T14189.stderr | 135 +++++++++++++++++++++
testsuite/tests/parser/should_compile/all.T | 1 +
4 files changed, 161 insertions(+), 18 deletions(-)
Diff suppressed because of size. To see it, use:
git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 9498c50ef5af2680305e0aaea6f32439cacc3da0
More information about the ghc-commits
mailing list