[commit: ghc] wip/perf-testsuite: Added initial metric comparison tooling (9c20d12)

[git at git.haskell.org]

Repository : ssh://git@git.haskell.org/ghc

On branch  : wip/perf-testsuite
Link       : http://ghc.haskell.org/trac/ghc/changeset/9c20d122f901b8477ce9809201de6eda26cc5855/ghc

>---------------------------------------------------------------

commit 9c20d122f901b8477ce9809201de6eda26cc5855
Author: Jared Weakly <jweakly at pdx.edu>
Date:   Thu Jul 20 17:30:21 2017 -0700

    Added initial metric comparison tooling


>---------------------------------------------------------------

9c20d122f901b8477ce9809201de6eda26cc5855
 testsuite/driver/runtests.py | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/testsuite/driver/runtests.py b/testsuite/driver/runtests.py
index 1aa691d..8177b24 100644
--- a/testsuite/driver/runtests.py
+++ b/testsuite/driver/runtests.py
@@ -307,14 +307,11 @@ else:
 
     summary(t, sys.stdout, config.no_print_summary)
 
-    # This here is loading up all of the git notes into memory.
-    # It's most likely in the wrong spot and I haven't fully fleshed out
-    # where exactly I'm putting this and how I'm refactoring the performance
-    # test running logic.
-    # Currently this is useful for debugging, at least.
+    # Write our accumulated metrics into the git notes for this commit.
     if config.use_git_notes:
             note = subprocess.check_output(["git","notes","--ref=perf","append","-m", "\n".join(config.accumulate_metrics)])
-            parse_git_notes('perf') # Should this be hardcoded? Most likely not...
+            # v-- This is in a nonsensical area. It should be happening before all of the tests are even run.
+            # parse_git_notes('perf') # Should it even be happening in the test-driver logic anymore?
 
     # Write our accumulated metrics into the git notes for this commit.
     if config.use_git_notes: