[commit: ghc] wip/perf-testsuite: Small changes to address Ben's comments (58d179e)
git at git.haskell.org
git at git.haskell.org
Sat Sep 2 21:46:13 UTC 2017
Repository : ssh://git@git.haskell.org/ghc
On branch : wip/perf-testsuite
Link : http://ghc.haskell.org/trac/ghc/changeset/58d179eec838331761533d863a8b85eaeb525a3b/ghc
>---------------------------------------------------------------
commit 58d179eec838331761533d863a8b85eaeb525a3b
Author: Jared Weakly <jweakly at pdx.edu>
Date: Tue Jul 18 17:35:34 2017 -0700
Small changes to address Ben's comments
Signed-off-by: Jared Weakly <jweakly at pdx.edu>
>---------------------------------------------------------------
58d179eec838331761533d863a8b85eaeb525a3b
testsuite/driver/runtests.py | 5 +++++
testsuite/driver/testlib.py | 1 -
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/testsuite/driver/runtests.py b/testsuite/driver/runtests.py
index 621c0bb..fe7aa61 100644
--- a/testsuite/driver/runtests.py
+++ b/testsuite/driver/runtests.py
@@ -329,6 +329,11 @@ else:
summary(t, sys.stdout, config.no_print_summary)
+ # This here is loading up all of the git notes into memory.
+ # It's most likely in the wrong spot and I haven't fully fleshed out
+ # where exactly I'm putting this and how I'm refactoring the performance
+ # test running logic.
+ # Currently this is useful for debugging, at least.
if config.use_git_notes:
note = subprocess.check_output(["git","notes","--ref=perf","append","-m", "\n".join(config.accumulate_metrics)])
parse_git_notes('perf') # Should this be hardcoded? Most likely not...
diff --git a/testsuite/driver/testlib.py b/testsuite/driver/testlib.py
index a24ee6c..8fc3ed7 100644
--- a/testsuite/driver/testlib.py
+++ b/testsuite/driver/testlib.py
@@ -1086,7 +1086,6 @@ def stats( name, way, stats_file ):
# Check -t stats info
def checkStats(name, way, stats_file, range_fields):
-
full_name = name + '(' + way + ')'
result = passed()
More information about the ghc-commits
mailing list