[commit: ghc] master: ApplicativeDo: handle BodyStmt (#12143) (41f9055)
git at git.haskell.org
git at git.haskell.org
Fri Oct 27 13:48:48 UTC 2017
Repository : ssh://git@git.haskell.org/ghc
On branch : master
Link : http://ghc.haskell.org/trac/ghc/changeset/41f905596dc2560f29657753e4c69ce695161786/ghc
>---------------------------------------------------------------
commit 41f905596dc2560f29657753e4c69ce695161786
Author: Simon Marlow <marlowsd at gmail.com>
Date: Thu Oct 26 11:23:23 2017 +0100
ApplicativeDo: handle BodyStmt (#12143)
Summary:
It's simple to treat BodyStmt just like a BindStmt with a wildcard
pattern, which is enough to fix #12143 without going all the way to
using `<*` and `*>` (#10892).
Test Plan:
* new test cases in `ado004.hs`
* validate
Reviewers: niteria, simonpj, bgamari, austin, erikd
Subscribers: rwbarton, thomie
GHC Trac Issues: #12143
Differential Revision: https://phabricator.haskell.org/D4128
>---------------------------------------------------------------
41f905596dc2560f29657753e4c69ce695161786
compiler/deSugar/Coverage.hs | 7 +++--
compiler/deSugar/DsExpr.hs | 2 +-
compiler/hsSyn/HsExpr.hs | 57 +++++++++++++++++++++++++++++++++------
compiler/hsSyn/HsUtils.hs | 2 +-
compiler/rename/RnExpr.hs | 11 ++++++--
compiler/typecheck/TcHsSyn.hs | 10 +++----
compiler/typecheck/TcMatches.hs | 6 ++---
testsuite/tests/ado/ado004.hs | 18 +++++++++++++
testsuite/tests/ado/ado004.stderr | 8 ++++++
9 files changed, 99 insertions(+), 22 deletions(-)
Diff suppressed because of size. To see it, use:
git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 41f905596dc2560f29657753e4c69ce695161786
More information about the ghc-commits
mailing list