[commit: ghc] wip/nfs-locking: Don't print empty arguments. (2bde60d)

git at git.haskell.org git at git.haskell.org
Fri Oct 27 00:46:55 UTC 2017


Repository : ssh://git@git.haskell.org/ghc

On branch  : wip/nfs-locking
Link       : http://ghc.haskell.org/trac/ghc/changeset/2bde60d83dd71c50b88f385efefef71bf27220d0/ghc

>---------------------------------------------------------------

commit 2bde60d83dd71c50b88f385efefef71bf27220d0
Author: Andrey Mokhov <andrey.mokhov at gmail.com>
Date:   Fri Feb 5 01:07:48 2016 +0000

    Don't print empty arguments.
    
    See #204.


>---------------------------------------------------------------

2bde60d83dd71c50b88f385efefef71bf27220d0
 src/Rules/Actions.hs | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/Rules/Actions.hs b/src/Rules/Actions.hs
index 658ba17..daa4c5e 100644
--- a/src/Rules/Actions.hs
+++ b/src/Rules/Actions.hs
@@ -98,7 +98,8 @@ fixFile file f = do
 runConfigure :: FilePath -> [CmdOption] -> [String] -> Action ()
 runConfigure dir opts args = do
     need [dir -/- "configure"]
-    let note = if null args || args == [""] then "" else " (" ++ intercalate ", " args ++ ")"
+    let args' = filter (not . null) args
+        note  = if null args' then "" else " (" ++ intercalate ", " args' ++ ")"
     if dir == "."
     then do
         putBuild $ "| Run configure" ++ note ++ "..."



More information about the ghc-commits mailing list