[commit: ghc] wip/nfs-locking: Make Objdump builder optional. (d89358f)

[git at git.haskell.org]

Repository : ssh://git@git.haskell.org/ghc

On branch  : wip/nfs-locking
Link       : http://ghc.haskell.org/trac/ghc/changeset/d89358f615755e5482e526c38d52cef76cfb3b7e/ghc

>---------------------------------------------------------------

commit d89358f615755e5482e526c38d52cef76cfb3b7e
Author: Andrey Mokhov <andrey.mokhov at gmail.com>
Date:   Sat Mar 5 13:17:23 2016 +0000

    Make Objdump builder optional.
    
    See #211.


>---------------------------------------------------------------

d89358f615755e5482e526c38d52cef76cfb3b7e
 src/Builder.hs | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/Builder.hs b/src/Builder.hs
index eee24cb..e8011e7 100644
--- a/src/Builder.hs
+++ b/src/Builder.hs
@@ -86,9 +86,14 @@ isStaged = \case
     (GhcPkg _) -> True
     _          -> False
 
+-- TODO: Some builders are required only on certain platforms. For example,
+-- Objdump is only required on OpenBSD and AIX, as mentioned in #211. Add
+-- support for platform-specific optional builders as soon as we can reliably
+-- test this feature.
 isOptional :: Builder -> Bool
 isOptional = \case
     HsColour -> True
+    Objdump  -> True
     _        -> False
 
 -- TODO: get rid of fromJust