[commit: ghc] wip/nfs-locking: Drop TODOs (456a10b)
git at git.haskell.org
git at git.haskell.org
Fri Oct 27 00:22:57 UTC 2017
Repository : ssh://git@git.haskell.org/ghc
On branch : wip/nfs-locking
Link : http://ghc.haskell.org/trac/ghc/changeset/456a10bc8d12b8b2ac17c28279f35f5b675702d8/ghc
>---------------------------------------------------------------
commit 456a10bc8d12b8b2ac17c28279f35f5b675702d8
Author: Andrey Mokhov <andrey.mokhov at gmail.com>
Date: Mon Oct 3 01:21:11 2016 +0900
Drop TODOs
See #113
>---------------------------------------------------------------
456a10bc8d12b8b2ac17c28279f35f5b675702d8
src/Rules/Generate.hs | 1 -
src/Rules/Library.hs | 2 +-
src/Settings/Packages/IntegerGmp.hs | 1 -
3 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/Rules/Generate.hs b/src/Rules/Generate.hs
index d7068cf..266141f 100644
--- a/src/Rules/Generate.hs
+++ b/src/Rules/Generate.hs
@@ -40,7 +40,6 @@ primopsTxt stage = buildPath (vanillaContext stage compiler) -/- "primops.txt"
platformH :: Stage -> FilePath
platformH stage = buildPath (vanillaContext stage compiler) -/- "ghc_boot_platform.h"
--- TODO: move generated files to buildRootPath, see #113
includesDependencies :: [FilePath]
includesDependencies = fmap (generatedPath -/-)
[ "ghcautoconf.h"
diff --git a/src/Rules/Library.hs b/src/Rules/Library.hs
index c2d56b4..00a6be2 100644
--- a/src/Rules/Library.hs
+++ b/src/Rules/Library.hs
@@ -97,6 +97,6 @@ hSources context = do
extraObjects :: Context -> Action [FilePath]
extraObjects context
| context == gmpContext = do
- need [gmpLibraryH] -- TODO: Move this dependency elsewhere, #113?
+ need [gmpLibraryH]
map unifyPath <$> getDirectoryFiles "" [gmpObjects -/- "*.o"]
| otherwise = return []
diff --git a/src/Settings/Packages/IntegerGmp.hs b/src/Settings/Packages/IntegerGmp.hs
index 7de3846..93ab4ed 100644
--- a/src/Settings/Packages/IntegerGmp.hs
+++ b/src/Settings/Packages/IntegerGmp.hs
@@ -6,7 +6,6 @@ import Oracles.Config.Setting
import Predicate
import Settings.Paths
--- TODO: move build artefacts to buildRootPath, see #113
-- TODO: Is this needed?
-- ifeq "$(GMP_PREFER_FRAMEWORK)" "YES"
-- libraries/integer-gmp_CONFIGURE_OPTS += --with-gmp-framework-preferred
More information about the ghc-commits
mailing list