[commit: ghc] master: Add info about Github pull requests. (bd53b48)

git at git.haskell.org git at git.haskell.org
Wed Oct 25 19:47:45 UTC 2017


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/bd53b488d6bf59329f33a5fb6ba2ef0170285298/ghc

>---------------------------------------------------------------

commit bd53b488d6bf59329f33a5fb6ba2ef0170285298
Author: AndreasPK <klebinger.andreas at gmx.at>
Date:   Fri Oct 20 23:53:54 2017 +0200

    Add info about Github pull requests.


>---------------------------------------------------------------

bd53b488d6bf59329f33a5fb6ba2ef0170285298
 HACKING.md | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/HACKING.md b/HACKING.md
index ecfd35b..cb68889 100644
--- a/HACKING.md
+++ b/HACKING.md
@@ -61,12 +61,12 @@ newly built compiler.
 
 Now, hack on your copy and rebuild (with `make`) as necessary.
 
-Then start by making your commits however you want. When you're done, you'll
-need to submit your patch to [Phabricator](https://phabricator.haskell.org/) for
-code review. To do so you will need to
-[install Arcanist](https://secure.phabricator.com/book/phabricator/article/arcanist/#installing-arcanist),
-Phabricator's CLI tool. Once installed, you can submit your work for code review
-using `arc diff`.
+Then start by making your commits however you want. When you're done, you can submit
+ a pull request on Github for small changes. For larger changes the patch needs to be
+ submitted to [Phabricator](https://phabricator.haskell.org/) for code review.
+ The GHC Trac Wiki has a good summary for the [overall process](https://ghc.haskell.org/trac/ghc/wiki/WorkingConventions/FixingBugs)
+ as well as a guide on 
+ [how to use Phabricator/arcanist](https://ghc.haskell.org/trac/ghc/wiki/Phabricator).
 
 
 Useful links:



More information about the ghc-commits mailing list