[commit: arcanist-external-json-linter] master: Fix handling of code and original fields (957f9e4)

git at git.haskell.org git at git.haskell.org
Thu Oct 19 12:55:26 UTC 2017


Repository : ssh://git@ghc/arcanist-external-json-linter

On branch  : master
Link       : http://git.haskell.org/arcanist-external-json-linter.git/commitdiff/957f9e4e8eb422dcb72f02f07767a1ed5969baab

>---------------------------------------------------------------

commit 957f9e4e8eb422dcb72f02f07767a1ed5969baab
Author: Ben Gamari <ben at smart-cactus.org>
Date:   Thu Oct 19 08:54:40 2017 -0400

    Fix handling of code and original fields
    
    Thanks to @sujeet for pointing this out.


>---------------------------------------------------------------

957f9e4e8eb422dcb72f02f07767a1ed5969baab
 src/ArcanistExternalJsonLinter.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/ArcanistExternalJsonLinter.php b/src/ArcanistExternalJsonLinter.php
index 6527f7d..9a09310 100644
--- a/src/ArcanistExternalJsonLinter.php
+++ b/src/ArcanistExternalJsonLinter.php
@@ -179,14 +179,14 @@ final class ArcanistExternalJsonLinter extends ArcanistLinter {
         ->setPath($path)
         ->setLine($line)
         ->setChar($char)
-        ->setCode($this->getLinterName())
+        ->setCode($code)
         ->setSeverity($severity)
         ->setName($name)
         ->setDescription($description);
 
       $original = idx($message, 'original');
       if ($original !== null) {
-        $lint->setOriginalText($originalText);
+        $lint->setOriginalText($original);
       }
 
       $replacement = idx($message, 'replacement');



More information about the ghc-commits mailing list