[commit: ghc] master: Pretty-printing of derived multi-parameter classes omits parentheses (6869864)
git at git.haskell.org
git at git.haskell.org
Wed Oct 11 14:00:38 UTC 2017
Repository : ssh://git@git.haskell.org/ghc
On branch : master
Link : http://ghc.haskell.org/trac/ghc/changeset/6869864eac211885edcd4b14425fd368069e4aba/ghc
>---------------------------------------------------------------
commit 6869864eac211885edcd4b14425fd368069e4aba
Author: Alan Zimmerman <alan.zimm at gmail.com>
Date: Sun Oct 1 19:36:03 2017 +0200
Pretty-printing of derived multi-parameter classes omits parentheses
Summary:
Pretty printing a splice with an HsAppType in the deriving clause, such as
$([d| data Foo a = Foo a deriving (C a) |])
would omit the parens.
Test Plan: ./validate
Reviewers: RyanGlScott, austin, bgamari
Subscribers: rwbarton, thomie
GHC Trac Issues: #14289
Differential Revision: https://phabricator.haskell.org/D4056
>---------------------------------------------------------------
6869864eac211885edcd4b14425fd368069e4aba
compiler/hsSyn/Convert.hs | 30 +++++++++++++++++++++---
compiler/hsSyn/HsDecls.hs | 5 ++--
compiler/hsSyn/HsTypes.hs | 13 ++++++++++-
testsuite/tests/printer/Makefile | 12 ++++++++++
testsuite/tests/printer/T14289.hs | 32 ++++++++++++++++++++++++++
testsuite/tests/printer/T14289.stdout | 16 +++++++++++++
testsuite/tests/printer/T14289b.hs | 42 ++++++++++++++++++++++++++++++++++
testsuite/tests/printer/T14289b.stdout | 16 +++++++++++++
testsuite/tests/printer/T14289c.hs | 40 ++++++++++++++++++++++++++++++++
testsuite/tests/printer/T14289c.stdout | 16 +++++++++++++
testsuite/tests/printer/all.T | 3 +++
11 files changed, 219 insertions(+), 6 deletions(-)
Diff suppressed because of size. To see it, use:
git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 6869864eac211885edcd4b14425fd368069e4aba
More information about the ghc-commits
mailing list