[commit: ghc] master: Incorporate changes from #11721 into Template Haskell (341d3a7)
git at git.haskell.org
git at git.haskell.org
Sat Oct 7 21:07:36 UTC 2017
Repository : ssh://git@git.haskell.org/ghc
On branch : master
Link : http://ghc.haskell.org/trac/ghc/changeset/341d3a7896385f14580d048ea7681232e5b242ce/ghc
>---------------------------------------------------------------
commit 341d3a7896385f14580d048ea7681232e5b242ce
Author: Ryan Scott <ryan.gl.scott at gmail.com>
Date: Sat Oct 7 16:58:56 2017 -0400
Incorporate changes from #11721 into Template Haskell
Summary:
#11721 changed the order of type variables in GADT
constructor type signatures, but these changes weren't reflected in
Template Haskell reification of GADTs. Let's do that.
Along the way, I:
* noticed that the `T13885` test was claiming to test TH reification
of GADTs, but the reified data type wasn't actually a GADT! Since
this patch touches that part of the codebase, I decided to fix
this.
* incorporated some feedback from @simonpj in
https://phabricator.haskell.org/D3687#113566. (These changes alone
don't account for any different in behavior.)
Test Plan: make test TEST=T11721_TH
Reviewers: goldfire, austin, bgamari, simonpj
Reviewed By: goldfire, bgamari, simonpj
Subscribers: rwbarton, thomie, simonpj
GHC Trac Issues: #11721
Differential Revision: https://phabricator.haskell.org/D4070
>---------------------------------------------------------------
341d3a7896385f14580d048ea7681232e5b242ce
compiler/basicTypes/DataCon.hs | 27 ++++++++++++++-------------
compiler/basicTypes/DataCon.hs-boot | 1 -
compiler/typecheck/TcSplice.hs | 20 +++++++++++---------
docs/users_guide/8.4.1-notes.rst | 10 ++++++++++
testsuite/tests/th/T11721_TH.hs | 26 ++++++++++++++++++++++++++
testsuite/tests/th/T13885.hs | 5 +++--
testsuite/tests/th/all.T | 1 +
7 files changed, 65 insertions(+), 25 deletions(-)
Diff suppressed because of size. To see it, use:
git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 341d3a7896385f14580d048ea7681232e5b242ce
More information about the ghc-commits
mailing list