[commit: haddock] wip/revert-ttg-2017-11-20: Revert "Match Trees That Grow" (ef7839c)

git at git.haskell.org git at git.haskell.org
Tue Nov 28 11:56:48 UTC 2017


Repository : ssh://git@git.haskell.org/haddock

On branch  : wip/revert-ttg-2017-11-20
Link       : http://git.haskell.org/haddock.git/commitdiff/ef7839c8423caf535e47c3cdc725073d22c18b58

>---------------------------------------------------------------

commit ef7839c8423caf535e47c3cdc725073d22c18b58
Author: Alan Zimmerman <alan.zimm at gmail.com>
Date:   Mon Nov 20 22:38:11 2017 +0200

    Revert "Match Trees That Grow"
    
    This reverts commit 73a26af844ac50b8bec39de11d64452a6286b00c.


>---------------------------------------------------------------

ef7839c8423caf535e47c3cdc725073d22c18b58
 haddock-api/src/Haddock/Interface/Create.hs     | 4 ++--
 haddock-api/src/Haddock/Interface/Specialize.hs | 5 +++--
 haddock-api/src/Haddock/Types.hs                | 3 ---
 3 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/haddock-api/src/Haddock/Interface/Create.hs b/haddock-api/src/Haddock/Interface/Create.hs
index 357cd78..c6a67af 100644
--- a/haddock-api/src/Haddock/Interface/Create.hs
+++ b/haddock-api/src/Haddock/Interface/Create.hs
@@ -520,10 +520,10 @@ ungroup group_ =
   mkDecls (typesigs . hs_valds)  SigD   group_ ++
   mkDecls (valbinds . hs_valds)  ValD   group_
   where
-    typesigs (XValBindsLR (NValBinds _ sigs)) = filter isUserLSig sigs
+    typesigs (ValBindsOut _ sigs) = filter isUserLSig sigs
     typesigs _ = error "expected ValBindsOut"
 
-    valbinds (XValBindsLR (NValBinds binds _)) = concatMap bagToList . snd . unzip $ binds
+    valbinds (ValBindsOut binds _) = concatMap bagToList . snd . unzip $ binds
     valbinds _ = error "expected ValBindsOut"
 
 
diff --git a/haddock-api/src/Haddock/Interface/Specialize.hs b/haddock-api/src/Haddock/Interface/Specialize.hs
index f0cf08a..0cac818 100644
--- a/haddock-api/src/Haddock/Interface/Specialize.hs
+++ b/haddock-api/src/Haddock/Interface/Specialize.hs
@@ -203,11 +203,12 @@ setInternalOccName occ name =
 
 
 -- | Compute set of free variables of given type.
-freeVariables :: HsType GhcRn -> Set Name
+freeVariables :: forall p. (NamedThing (IdP p), DataId p, Typeable p)
+              => HsType p -> Set Name
 freeVariables =
     everythingWithState Set.empty Set.union query
   where
-    query term ctx = case cast term :: Maybe (HsType GhcRn) of
+    query term ctx = case cast term :: Maybe (HsType p) of
         Just (HsForAllTy _ bndrs _) ->
             (Set.empty, Set.union ctx (bndrsNames bndrs))
         Just (HsTyVar _ _ (L _ name))
diff --git a/haddock-api/src/Haddock/Types.hs b/haddock-api/src/Haddock/Types.hs
index bb8ea9c..f0f1b2f 100644
--- a/haddock-api/src/Haddock/Types.hs
+++ b/haddock-api/src/Haddock/Types.hs
@@ -697,6 +697,3 @@ type instance XXTyVarBndr   DocNameI = PlaceHolder
 
 type instance XFieldOcc    DocNameI = DocName
 type instance XXFieldOcc   DocNameI = PlaceHolder
-
-type instance XValBinds    DocNameI DocNameI = PlaceHolder
-type instance XXValBindsLR DocNameI DocNameI = NHsValBindsLR DocNameI



More information about the ghc-commits mailing list