[commit: haddock] ghc-head, ghc-head1, ie_avails, wip/T14529, wip/new-tree-one-param, wip/revert-ttg-2017-11-20, wip/ttg-2017-10-13, wip/ttg-2017-10-31, wip/ttg-2017-11-06, wip/ttg2-2017-11-10, wip/ttg3-2017-11-12, wip/ttg4-constraints-2017-11-13, wip/ttg6-unrevert-2017-11-22: Render (signature) only if it actually is a signature! (a0c4790)

git at git.haskell.org git at git.haskell.org
Tue Nov 28 11:51:20 UTC 2017


Repository : ssh://git@git.haskell.org/haddock

On branches: ghc-head,ghc-head1,ie_avails,wip/T14529,wip/new-tree-one-param,wip/revert-ttg-2017-11-20,wip/ttg-2017-10-13,wip/ttg-2017-10-31,wip/ttg-2017-11-06,wip/ttg2-2017-11-10,wip/ttg3-2017-11-12,wip/ttg4-constraints-2017-11-13,wip/ttg6-unrevert-2017-11-22
Link       : http://git.haskell.org/haddock.git/commitdiff/a0c4790e15a2d3fab8d830eee8fcd639fe6d39c9

>---------------------------------------------------------------

commit a0c4790e15a2d3fab8d830eee8fcd639fe6d39c9
Author: Edward Z. Yang <ezyang at cs.stanford.edu>
Date:   Sat Apr 22 20:38:26 2017 -0700

    Render (signature) only if it actually is a signature!
    
    I forgot a conditional, oops!
    
    Signed-off-by: Edward Z. Yang <ezyang at cs.stanford.edu>


>---------------------------------------------------------------

a0c4790e15a2d3fab8d830eee8fcd639fe6d39c9
 haddock-api/src/Haddock/Backends/Xhtml.hs | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/haddock-api/src/Haddock/Backends/Xhtml.hs b/haddock-api/src/Haddock/Backends/Xhtml.hs
index 7b5f901..0c9abbf 100644
--- a/haddock-api/src/Haddock/Backends/Xhtml.hs
+++ b/haddock-api/src/Haddock/Backends/Xhtml.hs
@@ -486,10 +486,13 @@ ppHtmlModule odir doctitle themes
       mdl_str_annot = mdl_str ++ if ifaceIsSig iface
                                     then " (signature)"
                                     else ""
-      mdl_str_linked = mdl_str +++
-                       " (signature" +++
+      mdl_str_linked
+        | ifaceIsSig iface
+        = mdl_str +++ " (signature" +++
                        sup << ("[" +++ anchor ! [href signatureDocURL] << "?" +++ "]" ) +++
                        ")"
+        | otherwise
+        = toHtml mdl_str
       real_qual = makeModuleQual qual aliases mdl
       html =
         headHtml mdl_str_annot (Just $ "mini_" ++ moduleHtmlFile mdl) themes maybe_mathjax_url +++



More information about the ghc-commits mailing list