[commit: ghc] wip/angerman/llvmng: Adds comments. (5b4e192)

git at git.haskell.org git at git.haskell.org
Tue Nov 14 14:26:23 UTC 2017


Repository : ssh://git@git.haskell.org/ghc

On branch  : wip/angerman/llvmng
Link       : http://ghc.haskell.org/trac/ghc/changeset/5b4e19240e44eac2293355a08ac9019327da7661/ghc

>---------------------------------------------------------------

commit 5b4e19240e44eac2293355a08ac9019327da7661
Author: Moritz Angermann <moritz.angermann at gmail.com>
Date:   Tue Nov 14 09:41:11 2017 +0800

    Adds comments.
    
    # Conflicts:
    #	hadrian


>---------------------------------------------------------------

5b4e19240e44eac2293355a08ac9019327da7661
 compiler/main/Packages.hs | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/compiler/main/Packages.hs b/compiler/main/Packages.hs
index 6effbab..c49581b 100644
--- a/compiler/main/Packages.hs
+++ b/compiler/main/Packages.hs
@@ -1729,6 +1729,17 @@ packageHsLibs dflags p = map (mkDynName . addSuffix) (hsLibraries p)
          | otherwise
             = panic ("Don't understand library name " ++ x)
 
+        -- Add _thr and other rts suffixes to packages named
+        -- `rts` or `rts-1.0`. Why both?  Traditionally the rts
+        -- package is called `rts` only.  However the tooling
+        -- usually expects a package name to have a version.
+        -- As such we will gradually move towards the `rts-1.0`
+        -- package name, at which point the `rts` package name
+        -- will eventually be unused.
+        --
+        -- This change elevates the need to add custom hooks
+        -- and handling specifically for the `rts` package for
+        -- example in ghc-cabal.
         addSuffix rts@"HSrts"    = rts       ++ (expandTag rts_tag)
         addSuffix rts@"HSrts-1.0"= rts       ++ (expandTag rts_tag)
         addSuffix other_lib      = other_lib ++ (expandTag tag)



More information about the ghc-commits mailing list