[commit: ghc] master: Revert "Use a deterministic map for imp_dep_mods" (8bf50d5)

git at git.haskell.org git at git.haskell.org
Mon May 15 11:46:01 UTC 2017


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/8bf50d5026f92eb5a6768eb2ac38479802da1411/ghc

>---------------------------------------------------------------

commit 8bf50d5026f92eb5a6768eb2ac38479802da1411
Author: Bartosz Nitka <niteria at gmail.com>
Date:   Mon May 15 04:44:35 2017 -0700

    Revert "Use a deterministic map for imp_dep_mods"
    
    This reverts commit 7fea7121ce195e562a5443c0a8ef3861504ef1b3.
    It turns out that on a newly added MultiLayerModules test
    case it gets very expensive to union the transitive module
    sets while preserving determinism.
    
    Fortunately, we can just sort to restore determinism
    when converting imp_dep_mods to a list.
    
    Test Plan: ./validate
    
    Reviewers: simonmar, austin, bgamari
    
    Reviewed By: bgamari
    
    Subscribers: rwbarton, thomie
    
    Differential Revision: https://phabricator.haskell.org/D3577


>---------------------------------------------------------------

8bf50d5026f92eb5a6768eb2ac38479802da1411
 compiler/deSugar/DsUsage.hs         |  4 ++--
 compiler/iface/MkIface.hs           |  5 ++---
 compiler/typecheck/TcRnDriver.hs    | 14 +++++++-------
 compiler/typecheck/TcRnTypes.hs     | 24 ++++++++++++++++--------
 testsuite/tests/perf/compiler/all.T |  3 ++-
 5 files changed, 29 insertions(+), 21 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 8bf50d5026f92eb5a6768eb2ac38479802da1411


More information about the ghc-commits mailing list