[commit: ghc] master: Improve tracing in OccurAnal (5671e22)

git at git.haskell.org git at git.haskell.org
Fri Mar 24 14:14:57 UTC 2017


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/5671e22e913c60a0b5be4ddb3caa55fe8398b14f/ghc

>---------------------------------------------------------------

commit 5671e22e913c60a0b5be4ddb3caa55fe8398b14f
Author: Matthew Pickering <matthewtpickering at gmail.com>
Date:   Thu Mar 23 21:00:08 2017 -0400

    Improve tracing in OccurAnal
    
    One commented out tracing function didn't type check and also show the
    scores of loop breaker nodes.
    
    Reviewers: austin, bgamari
    
    Reviewed By: bgamari
    
    Subscribers: rwbarton, thomie
    
    Differential Revision: https://phabricator.haskell.org/D3371


>---------------------------------------------------------------

5671e22e913c60a0b5be4ddb3caa55fe8398b14f
 compiler/simplCore/OccurAnal.hs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/compiler/simplCore/OccurAnal.hs b/compiler/simplCore/OccurAnal.hs
index 6093f42..b14dbd9 100644
--- a/compiler/simplCore/OccurAnal.hs
+++ b/compiler/simplCore/OccurAnal.hs
@@ -892,7 +892,6 @@ occAnalRec lvl (CyclicSCC details_s) (body_uds, binds)
   | otherwise   -- At this point we always build a single Rec
   = -- pprTrace "occAnalRec" (vcat
     --  [ text "weak_fvs" <+> ppr weak_fvs
-    --  , text "tagged details" <+> ppr tagged_details_s
     --  , text "lb nodes" <+> ppr loop_breaker_nodes])
     (final_uds, Rec pairs : binds)
 
@@ -1204,6 +1203,7 @@ instance Outputable Details where
                   , text "inl =" <+> ppr (nd_inl nd)
                   , text "weak =" <+> ppr (nd_weak nd)
                   , text "rule =" <+> ppr (nd_active_rule_fvs nd)
+                  , text "score =" <+> ppr (nd_score nd)
              ])
 
 -- The NodeScore is compared lexicographically;



More information about the ghc-commits mailing list