[commit: ghc] master: Desugar: Refactor initDs (4bd2232)

git at git.haskell.org git at git.haskell.org
Tue Mar 7 20:07:05 UTC 2017


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/4bd2232754f2c0b365177d177e6d749c64e73176/ghc

>---------------------------------------------------------------

commit 4bd2232754f2c0b365177d177e6d749c64e73176
Author: Ben Gamari <bgamari.foss at gmail.com>
Date:   Tue Mar 7 14:30:38 2017 -0500

    Desugar: Refactor initDs
    
    As far as I can tell we were unnecessarily building a new TcgEnv when we
    already had one on hand. TcRnMonad now sports an initTcWithGbl function,
    which allows us to run a TcM monad in the context of this TcgEnv. This
    appears to simplify things nicely.
    
    Test Plan: Validate
    
    Reviewers: austin
    
    Subscribers: dfeuer, simonpj, thomie
    
    Differential Revision: https://phabricator.haskell.org/D3228


>---------------------------------------------------------------

4bd2232754f2c0b365177d177e6d749c64e73176
 compiler/deSugar/Desugar.hs           |   6 +-
 compiler/deSugar/DsMonad.hs           | 123 ++++++++++++++++++++--------------
 compiler/typecheck/TcRnMonad.hs       |  51 ++++++++------
 compiler/vectorise/Vectorise/Monad.hs |  13 ++--
 4 files changed, 110 insertions(+), 83 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 4bd2232754f2c0b365177d177e6d749c64e73176


More information about the ghc-commits mailing list