[commit: ghc] ghc-8.2: compiler: Eliminate pprTrace in SPT entry addition codepath (0fa0d6c)

git at git.haskell.org git at git.haskell.org
Fri Jun 23 18:51:57 UTC 2017


Repository : ssh://git@git.haskell.org/ghc

On branch  : ghc-8.2
Link       : http://ghc.haskell.org/trac/ghc/changeset/0fa0d6c2d64dc41783e04b5887f96a996a181d3b/ghc

>---------------------------------------------------------------

commit 0fa0d6c2d64dc41783e04b5887f96a996a181d3b
Author: Ben Gamari <bgamari.foss at gmail.com>
Date:   Fri Jun 23 11:35:48 2017 -0400

    compiler: Eliminate pprTrace in SPT entry addition codepath
    
    Test Plan: Load program with StaticPointers into GHCi, ensure no
    tracing output makes it in.
    
    Reviewers: austin
    
    Subscribers: rwbarton, thomie, RyanGlScott
    
    GHC Trac Issues: #12356
    
    Differential Revision: https://phabricator.haskell.org/D3663
    
    (cherry picked from commit 84cf095dc981ea21fcceddbb71463dd7844754ca)


>---------------------------------------------------------------

0fa0d6c2d64dc41783e04b5887f96a996a181d3b
 compiler/main/HscMain.hs | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/compiler/main/HscMain.hs b/compiler/main/HscMain.hs
index fd8c2c0..43dc5a1 100644
--- a/compiler/main/HscMain.hs
+++ b/compiler/main/HscMain.hs
@@ -1613,8 +1613,7 @@ hscAddSptEntries hsc_env entries = do
     let add_spt_entry :: SptEntry -> IO ()
         add_spt_entry (SptEntry i fpr) = do
             val <- getHValue hsc_env (idName i)
-            pprTrace "add_spt_entry" (ppr fpr <+> ppr i) $
-                addSptEntry hsc_env fpr val
+            addSptEntry hsc_env fpr val
     mapM_ add_spt_entry entries
 
 {-



More information about the ghc-commits mailing list