[commit: ghc] ghc-8.2: Fix #13948 by being pickier about when to suggest DataKinds (fb46561)

[git at git.haskell.org]

Repository : ssh://git@git.haskell.org/ghc

On branch  : ghc-8.2
Link       : http://ghc.haskell.org/trac/ghc/changeset/fb46561900480b8d9659ab3e9f8590a9a38a69ea/ghc

>---------------------------------------------------------------

commit fb46561900480b8d9659ab3e9f8590a9a38a69ea
Author: Ryan Scott <ryan.gl.scott at gmail.com>
Date:   Tue Jul 11 13:59:07 2017 -0400

    Fix #13948 by being pickier about when to suggest DataKinds
    
    Commit 343cb32d0983f576d344a2d04a35c3fd6eecf2c5 (#13568) made GHC a bit
    too cavalier in suggesting when data constructors are in scope (and
    suggesting the use of `DataKinds`). This tones down the suggestions so
    that `DataKinds` is only suggested if a data constructor of that name is
    actually in scope (previously, it would always suggest, even if it was
    out of scope).
    
    Fixes #13948.
    
    Test Plan: ./validate
    
    Reviewers: mpickering, austin, bgamari
    
    Reviewed By: mpickering
    
    Subscribers: rwbarton, thomie
    
    GHC Trac Issues: #13948
    
    Differential Revision: https://phabricator.haskell.org/D3719
    
    (cherry picked from commit ba46e63f3d6f7d0438a0262f6711f8a219c703bc)


>---------------------------------------------------------------

fb46561900480b8d9659ab3e9f8590a9a38a69ea
 compiler/rename/RnEnv.hs                               | 11 ++++++++++-
 testsuite/tests/module/mod122.stderr                   |  4 +---
 testsuite/tests/module/mod123.stderr                   |  4 +---
 testsuite/tests/module/mod124.stderr                   |  1 -
 testsuite/tests/module/mod127.stderr                   |  1 -
 testsuite/tests/module/mod29.stderr                    |  1 -
 testsuite/tests/module/mod50.stderr                    |  4 +---
 testsuite/tests/parser/should_fail/readFail001.stderr  |  1 -
 testsuite/tests/rename/prog003/rename.prog003.stderr   |  4 +---
 testsuite/tests/rename/should_fail/T1595a.stderr       |  1 -
 testsuite/tests/rename/should_fail/T5745.stderr        |  4 +---
 testsuite/tests/typecheck/should_fail/T1595.stderr     |  2 --
 testsuite/tests/typecheck/should_fail/tcfail048.stderr |  1 -
 testsuite/tests/typecheck/should_fail/tcfail053.stderr |  1 -
 14 files changed, 15 insertions(+), 25 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc fb46561900480b8d9659ab3e9f8590a9a38a69ea