[commit: packages/unix] backpack, bgamari-patch-1, master, readdirstream-maybe-patch: Testsuite: remove no_stdin (40820da)

git at git.haskell.org git at git.haskell.org
Wed Jul 19 22:04:10 UTC 2017


Repository : ssh://git@git.haskell.org/unix

On branches: backpack,bgamari-patch-1,master,readdirstream-maybe-patch
Link       : http://ghc.haskell.org/trac/ghc/changeset/40820da5fb35c53aed53c211277c3e6077c1ddf9/unix

>---------------------------------------------------------------

commit 40820da5fb35c53aed53c211277c3e6077c1ddf9
Author: Thomas Miedema <thomasmiedema at gmail.com>
Date:   Fri Jun 24 17:19:37 2016 +0200

    Testsuite: remove no_stdin
    
    `no_stdin` is no longer necessary, and has been removed from the
    testsuite driver


>---------------------------------------------------------------

40820da5fb35c53aed53c211277c3e6077c1ddf9
 tests/all.T | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/tests/all.T b/tests/all.T
index d878292..e2fcb88 100644
--- a/tests/all.T
+++ b/tests/all.T
@@ -11,19 +11,19 @@ test('forkprocess01', extra_ways(['threaded1_ls']), compile_and_run,
 # user001 may fail due to this bug in glibc:
 #   http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=466647
 #
-# user001 may also fail on GNU/Linux when using a terminal emulator that doesn't
-# write login records to /var/run/utmp. Running:
-#   $ logname
-# should print your login name. If it doesn't, the getLoginName test in user001
-# will fail, and that's why you are here. Try xterm.
-#
 # Ticket #1487. The glibc implementation of getlogin, which is called by
 # getLoginName, requires that a terminal is connected to filedescriptor 0.
 # See: https://sourceware.org/git/?p=glibc.git;a=blob;f=sysdeps/unix/getlogin.c
-# Therefore, we use the no_stdin option, and have to omit the 'ghci' way,
-# because it relies on redirecting stdin from file.
+# Therefore we have to omit the 'ghci' way, because it relies on redirecting
+# stdin from file.
+#
+# But getLoginName also fails on GNU/Linux when using a terminal emulator
+# that doesn't write login records to /var/run/utmp. Running:
+#   $ logname
+# should print your login name. If it doesn't, the getLoginName test in user001
+# would fail, so we disabled that test.
 #
-test('user001', [no_stdin, omit_ways(['ghci'])], compile_and_run, ['-package unix'])
+test('user001', omit_ways(['ghci']), compile_and_run, ['-package unix'])
 test('resourceLimit', normal, compile_and_run, ['-package unix'])
 
 x86FreeBsdFail = when(platform('i386-unknown-freebsd'), expect_fail)



More information about the ghc-commits mailing list