[commit: ghc] master: [skip ci] Temporarily disable split-sections on Windows. (f656fba)

git at git.haskell.org git at git.haskell.org
Thu Jul 13 20:07:19 UTC 2017


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/f656fba19d0cefe05643ddea35d080ea332a6584/ghc

>---------------------------------------------------------------

commit f656fba19d0cefe05643ddea35d080ea332a6584
Author: Tamar Christina <tamar at zhox.com>
Date:   Thu Jul 13 21:06:49 2017 +0100

    [skip ci] Temporarily disable split-sections on Windows.
    
    Summary:
    This temporarily disabled split-sections again on Windows because
    of the overhead in linking it introduces. Unfortunately because BFD
    is so slow a testsuite run gets almost 2x slower. Simply linking
    Hello World takes an unacceptable long time.
    
    So for now, it'll be disabled as we look into different linkers such
    as LLD.
    
    Test Plan: ./validate
    
    Reviewers: austin, bgamari
    
    Subscribers: rwbarton, thomie
    
    GHC Trac Issues: #12913
    
    Differential Revision: https://phabricator.haskell.org/D3731


>---------------------------------------------------------------

f656fba19d0cefe05643ddea35d080ea332a6584
 mk/config.mk.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/mk/config.mk.in b/mk/config.mk.in
index 88f3b51..2e920ca 100644
--- a/mk/config.mk.in
+++ b/mk/config.mk.in
@@ -357,8 +357,9 @@ SplitObjs = $(if $(and $(filter YES,$(SupportsSplitObjs)),\
 # Set SplitSections=YES or NO in your build.mk to override the default.
 #
 # This is not supported on Darwin (where you can use subsections-via-symbols
-# instead) and Windows is not yet working. (See #11445 and related tickets.)
-OsSupportsSplitSections=$(if $(filter $(TargetOS_CPP),darwin),NO,YES)
+# instead) and Windows is disabled until we figure the linking performance
+# issues related to BFD out. (See #11445, #12913 and related tickets.)
+OsSupportsSplitSections=$(if $(filter $(TargetOS_CPP),mingw32 darwin),NO,YES)
 SupportsSplitSections=$(if $(and $(filter YES,$(OsSupportsSplitSections)),\
                                    $(filter YES,$(LdIsGNULd))),YES,NO)
 SplitSections ?= $(SupportsSplitSections)



More information about the ghc-commits mailing list