[commit: ghc] master: Always use -Xlinker for -rpath (f9ccad2)

git at git.haskell.org git at git.haskell.org
Sat Jan 21 18:00:35 UTC 2017


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/f9ccad236fa6042a3abbb655129f47fe9dadceaf/ghc

>---------------------------------------------------------------

commit f9ccad236fa6042a3abbb655129f47fe9dadceaf
Author: Bartosz Nitka <niteria at gmail.com>
Date:   Sat Jan 21 09:59:55 2017 -0800

    Always use -Xlinker for -rpath
    
    Currently we use `-Wl` which takes a list of
    comma-separated options. Unfortunately that
    breaks when you use it with `-rpath` and
    a path that has commas in them.
    Buck, the build system, produces paths with
    commas in them.
    
    `-Xlinker` doesn't have this disadvantage
    and as far as I can tell is supported by
    both `gcc` and `clang`. Anecdotally `nvcc`
    supports `-Xlinker`, but not `-Wl`.
    
    Test Plan: ./validate, harbourmaster
    
    Reviewers: nomeata, simonmar, austin, bgamari, hvr
    
    Reviewed By: simonmar, bgamari
    
    Subscribers: thomie
    
    Differential Revision: https://phabricator.haskell.org/D2971


>---------------------------------------------------------------

f9ccad236fa6042a3abbb655129f47fe9dadceaf
 compiler/ghci/Linker.hs                            | 13 ++++---
 compiler/main/DriverPipeline.hs                    | 21 ++++++++++--
 compiler/main/SysTools.hs                          |  3 +-
 testsuite/driver/extra_files.py                    |  1 +
 testsuite/tests/th/TH_linker/Dummy.hs              |  1 +
 testsuite/tests/th/TH_linker/Main.hs               |  7 ++++
 testsuite/tests/th/TH_linker/Makefile              | 40 ++++++++++++++++++++++
 testsuite/tests/th/TH_linker/all.T                 |  4 +++
 .../TH_linker/path_with_commas.stdout}             |  5 ++-
 testsuite/tests/th/TH_linker/test.pkg              |  7 ++++
 10 files changed, 91 insertions(+), 11 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc f9ccad236fa6042a3abbb655129f47fe9dadceaf


More information about the ghc-commits mailing list