[commit: ghc] wip/all-inlinable: Move test to the end to only fire on uncovered cases (497aa52)

git at git.haskell.org git at git.haskell.org
Mon Jan 9 10:51:24 UTC 2017


Repository : ssh://git@git.haskell.org/ghc

On branch  : wip/all-inlinable
Link       : http://ghc.haskell.org/trac/ghc/changeset/497aa52a867021495360e7f21ac6e1f73753166e/ghc

>---------------------------------------------------------------

commit 497aa52a867021495360e7f21ac6e1f73753166e
Author: Matthew Pickering <matthewtpickering at gmail.com>
Date:   Mon Jan 9 10:51:05 2017 +0000

    Move test to the end to only fire on uncovered cases


>---------------------------------------------------------------

497aa52a867021495360e7f21ac6e1f73753166e
 compiler/main/TidyPgm.hs | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/compiler/main/TidyPgm.hs b/compiler/main/TidyPgm.hs
index 2f41b7a..6bbd556 100644
--- a/compiler/main/TidyPgm.hs
+++ b/compiler/main/TidyPgm.hs
@@ -739,14 +739,14 @@ addExternal expose_all id = (new_needed_ids, show_unfold)
 
        || isStableSource src     -- Always expose things whose
                                  -- source is an inline rule
-       || (if is_overloaded
-            then pprTrace "ADDITION UNFOLDING" (ppr id) True
-            else False)           -- Always expose overloaded things so that
-                                 -- they can be specialised at call sites.
        || not (bottoming_fn      -- No need to inline bottom functions
            || never_active       -- Or ones that say not to
            || loop_breaker       -- Or that are loop breakers
            || neverUnfoldGuidance guidance)
+       || (if is_overloaded
+            then pprTrace "ADDITIONAL UNFOLDING:" (ppr id) True
+            else False)           -- Always expose overloaded things so that
+                                 -- they can be specialised at call sites.
     show_unfolding (DFunUnfolding {}) = True
     show_unfolding _                  = False
 



More information about the ghc-commits mailing list