[commit: ghc] master: Refactor renaming of operators/sections to fix DuplicateRecordFields bugs (2484d4d)
git at git.haskell.org
git at git.haskell.org
Tue Feb 14 15:54:47 UTC 2017
Repository : ssh://git@git.haskell.org/ghc
On branch : master
Link : http://ghc.haskell.org/trac/ghc/changeset/2484d4dae65c81f218dcfe494b963b2630bb8fa6/ghc
>---------------------------------------------------------------
commit 2484d4dae65c81f218dcfe494b963b2630bb8fa6
Author: Adam Gundry <adam at well-typed.com>
Date: Tue Feb 14 09:35:06 2017 -0500
Refactor renaming of operators/sections to fix DuplicateRecordFields bugs
A variety of panics were possible because the get_op function in
RnTypes didn't handle the possibility that its argument might be an
ambiguous record field. I've made its return type more informative to
correctly handle occurrences of record fields. Fixes Trac #13132.
Test Plan: new test
overloadedrecflds/should_fail/T13132_duplicaterecflds
Reviewers: bgamari, simonpj, austin
Reviewed By: bgamari
Subscribers: thomie
Differential Revision: https://phabricator.haskell.org/D3126
>---------------------------------------------------------------
2484d4dae65c81f218dcfe494b963b2630bb8fa6
compiler/rename/RnTypes.hs | 74 +++++++++++++++-------
.../should_fail/T13132_duplicaterecflds.hs | 9 +++
.../should_fail/T13132_duplicaterecflds.stderr | 6 ++
.../tests/overloadedrecflds/should_fail/all.T | 1 +
4 files changed, 68 insertions(+), 22 deletions(-)
Diff suppressed because of size. To see it, use:
git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 2484d4dae65c81f218dcfe494b963b2630bb8fa6
More information about the ghc-commits
mailing list