[commit: ghc] master: TH-spliced class instances are pretty-printed incorrectly post-#3384 (258c719)

Fri Feb 10 10:42:58 UTC 2017

Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/258c719599f78178c75b58d9c49e10e498cb7c48/ghc

>---------------------------------------------------------------

commit 258c719599f78178c75b58d9c49e10e498cb7c48
Author: Alan Zimmerman <alan.zimm at gmail.com>
Date:   Sun Jan 29 22:35:41 2017 +0200

    TH-spliced class instances are pretty-printed incorrectly post-#3384

    Summary:
    The HsSyn prettyprinter tests patch 499e43824bda967546ebf95ee33ec1f84a114a7c
    broke the pretty-printing of Template Haskell-spliced class instances.

    Test Plan: ./validate

    Reviewers: RyanGlScott, austin, goldfire, bgamari

    Reviewed By: RyanGlScott, bgamari

    Subscribers: thomie

    Differential Revision: https://phabricator.haskell.org/D3043

>---------------------------------------------------------------

258c719599f78178c75b58d9c49e10e498cb7c48
 compiler/hsSyn/Convert.hs                          | 42 ++++++++++---
 compiler/hsSyn/HsExpr.hs                           | 34 +++++-----
 compiler/hsSyn/HsUtils.hs                          |  2 +-
 compiler/rename/RnSplice.hs                        |  6 --
 compiler/typecheck/TcExpr.hs                       |  2 +-
 compiler/typecheck/TcGenGenerics.hs                |  9 ++-
 compiler/typecheck/TcSplice.hs                     |  2 +-
 compiler/typecheck/TcTypeable.hs                   |  6 +-
 ghc/GHCi/UI.hs                                     |  3 +-
 testsuite/tests/ghci/scripts/T10508.stderr         |  2 +-
 .../should_compile/DumpTypecheckedAst.stderr       | 72 ++++++++++++----------
 testsuite/tests/printer/Makefile                   |  4 ++
 testsuite/tests/printer/T13199.hs                  | 38 ++++++++++++
 testsuite/tests/printer/T13199.stdout              | 48 +++++++++++++++
 testsuite/tests/printer/all.T                      |  1 +
 testsuite/tests/th/T12530.stderr                   |  2 +-
 16 files changed, 201 insertions(+), 72 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 258c719599f78178c75b58d9c49e10e498cb7c48