[commit: ghc] master: Fix comment of `section "Exceptions"` (3e07126)

git at git.haskell.org git at git.haskell.org
Wed Feb 8 03:40:35 UTC 2017


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/3e0712612a1e6c9b404e31b2a0175d8f9c5d443e/ghc

>---------------------------------------------------------------

commit 3e0712612a1e6c9b404e31b2a0175d8f9c5d443e
Author: Takenobu Tani <takenobu.hs at gmail.com>
Date:   Tue Feb 7 21:36:54 2017 -0500

    Fix comment of `section "Exceptions"`
    
    I changed comment from `{- .. -}` to `--`.
    Because Haddock comment for `section "Exceptions"` [1] was broken.
    
    [1]:
    https://downloads.haskell.org/~ghc/latest/docs/html/libraries/ghc-prim-0
    .5.0.0/GHC-Prim.html
    
    Reviewers: austin, bgamari
    
    Reviewed By: bgamari
    
    Subscribers: thomie
    
    Differential Revision: https://phabricator.haskell.org/D3083


>---------------------------------------------------------------

3e0712612a1e6c9b404e31b2a0175d8f9c5d443e
 compiler/prelude/primops.txt.pp | 25 ++++++++++++-------------
 1 file changed, 12 insertions(+), 13 deletions(-)

diff --git a/compiler/prelude/primops.txt.pp b/compiler/prelude/primops.txt.pp
index 5245272..533d198 100644
--- a/compiler/prelude/primops.txt.pp
+++ b/compiler/prelude/primops.txt.pp
@@ -1945,19 +1945,18 @@ primop  CasMutVarOp "casMutVar#" GenPrimOp
 section "Exceptions"
 ------------------------------------------------------------------------
 
-{- Note [Strictness for mask/unmask/catch]
-~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-Consider this example, which comes from GHC.IO.Handle.Internals:
-   wantReadableHandle3 f ma b st
-     = case ... of
-         DEFAULT -> case ma of MVar a -> ...
-         0#      -> maskAsynchExceptions# (\st -> case ma of MVar a -> ...)
-The outer case just decides whether to mask exceptions, but we don't want
-thereby to hide the strictness in 'ma'!  Hence the use of strictApply1Dmd.
-
-For catch, we must be extra careful; see
-Note [Exceptions and strictness] in Demand
--}
+-- Note [Strictness for mask/unmask/catch]
+-- ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+-- Consider this example, which comes from GHC.IO.Handle.Internals:
+--    wantReadableHandle3 f ma b st
+--      = case ... of
+--          DEFAULT -> case ma of MVar a -> ...
+--          0#      -> maskAsynchExceptions# (\st -> case ma of MVar a -> ...)
+-- The outer case just decides whether to mask exceptions, but we don't want
+-- thereby to hide the strictness in 'ma'!  Hence the use of strictApply1Dmd.
+--
+-- For catch, we must be extra careful; see
+-- Note [Exceptions and strictness] in Demand
 
 primop  CatchOp "catch#" GenPrimOp
           (State# RealWorld -> (# State# RealWorld, a #) )



More information about the ghc-commits mailing list