[commit: ghc] master: Make split sections by default work again (283acec)

git at git.haskell.org git at git.haskell.org
Sat Feb 4 10:33:24 UTC 2017


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/283acec1d7307fdbd8cd7b3f1d984a036366d6b4/ghc

>---------------------------------------------------------------

commit 283acec1d7307fdbd8cd7b3f1d984a036366d6b4
Author: Reid Barton <rwbarton at gmail.com>
Date:   Sat Feb 4 10:29:17 2017 +0000

    Make split sections by default work again
    
    Commit 266a9dc4c changed = to := in one place in mk/config.mk.in.
    This broke SupportsSplitSections because the variable LdIsGNULd
    that it depends on is not defined until later in the file.
    
    Test Plan: pushed to a wip/ branch for perf to build
    
    Reviewers: DemiMarie, austin, bgamari, mpickering
    
    Reviewed By: mpickering
    
    Subscribers: mpickering, thomie
    
    Differential Revision: https://phabricator.haskell.org/D3070
    
    GHC Trac Issues: #13230


>---------------------------------------------------------------

283acec1d7307fdbd8cd7b3f1d984a036366d6b4
 mk/config.mk.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mk/config.mk.in b/mk/config.mk.in
index f4508af..35ff04c 100644
--- a/mk/config.mk.in
+++ b/mk/config.mk.in
@@ -359,7 +359,7 @@ SplitObjs = $(if $(and $(filter YES,$(SupportsSplitObjs)),\
 # This is not supported on Darwin (where you can use subsections-via-symbols
 # instead) and Windows is not yet working. (See #11445 and related tickets.)
 OsSupportsSplitSections=$(if $(filter $(TargetOS_CPP),mingw32 darwin),NO,YES)
-SupportsSplitSections :=$(if $(and $(filter YES,$(OsSupportsSplitSections)),\
+SupportsSplitSections=$(if $(and $(filter YES,$(OsSupportsSplitSections)),\
                                    $(filter YES,$(LdIsGNULd))),YES,NO)
 SplitSections ?= $(SupportsSplitSections)
 



More information about the ghc-commits mailing list