[commit: ghc] master: Guard yet another /bin/sh `for in` loop against empty vars (cd10a23)

git at git.haskell.org git at git.haskell.org
Mon Apr 24 20:25:02 UTC 2017


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/cd10a23282499b474cedeb4f63f92e70ed9718f3/ghc

>---------------------------------------------------------------

commit cd10a23282499b474cedeb4f63f92e70ed9718f3
Author: Herbert Valerio Riedel <hvr at gnu.org>
Date:   Mon Apr 24 22:22:32 2017 +0200

    Guard yet another /bin/sh `for in` loop against empty vars
    
    This is a follow-up to df6794035f1e4397d89896f329525e5368b7d1cc
    which missed `INSTALL_BINS`


>---------------------------------------------------------------

cd10a23282499b474cedeb4f63f92e70ed9718f3
 ghc.mk | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/ghc.mk b/ghc.mk
index d36e681..ce71a55 100644
--- a/ghc.mk
+++ b/ghc.mk
@@ -907,9 +907,11 @@ endef
 
 install_bins: $(INSTALL_BINS) $(INSTALL_SCRIPTS)
 	$(INSTALL_DIR) "$(DESTDIR)$(bindir)"
+ifneq "$(INSTALL_BINS)" ""
 	for i in $(INSTALL_BINS); do \
 		$(INSTALL_PROGRAM) $(INSTALL_BIN_OPTS) $$i "$(DESTDIR)$(bindir)" ;  \
 	done
+endif
 ifneq "$(INSTALL_SCRIPTS)" ""
 	for i in $(INSTALL_SCRIPTS); do \
 		$(INSTALL_SCRIPT) $(INSTALL_OPTS) $$i "$(DESTDIR)$(bindir)" ;  \



More information about the ghc-commits mailing list