[commit: packages/containers] cleaned_bugfix394, master, merge-doc-target, merge-fixes-5.9, merge-restrict-fix-5.8, revert-408-bugfix_394: Remove pair rules (#253) (df3d647)

git at git.haskell.org git at git.haskell.org
Mon Apr 17 21:42:10 UTC 2017


Repository : ssh://git@git.haskell.org/containers

On branches: cleaned_bugfix394,master,merge-doc-target,merge-fixes-5.9,merge-restrict-fix-5.8,revert-408-bugfix_394
Link       : http://git.haskell.org/packages/containers.git/commitdiff/df3d64797a6c3ed812a9331707f6600dd0168d4e

>---------------------------------------------------------------

commit df3d64797a6c3ed812a9331707f6600dd0168d4e
Author: David Feuer <David.Feuer at gmail.com>
Date:   Mon May 23 17:27:07 2016 -0400

    Remove pair rules (#253)
    
    * Scrap alterF pair rewrite rules
    
    The rules rewrote to an overly strict implementation.
    Specifically, if the function gives us
    
    ```haskell
    (b, undefined :: Maybe a)
    ```
    
    then we need to produce
    
    ```haskell
    (b, undefined :: Map k a)
    ```
    
    Making the rules correct greatly reduces their benefit even
    when they're beneficial, and introduces situations where they
    may be harmful. So sadly I'm scrapping them.
    
    * Re-fix Haddock markup for alterF
    
    That was bundled with the reverted commits.


>---------------------------------------------------------------

df3d64797a6c3ed812a9331707f6600dd0168d4e
 Data/Map/Base.hs   | 61 +++++++-----------------------------------------------
 Data/Map/Strict.hs | 19 +++++++----------
 benchmarks/Map.hs  | 39 +++++++---------------------------
 3 files changed, 22 insertions(+), 97 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc df3d64797a6c3ed812a9331707f6600dd0168d4e


More information about the ghc-commits mailing list