[commit: packages/containers] changelog-foldtree, cleaned_bugfix394, master, merge-doc-target, merge-fixes-5.9, merge-restrict-fix-5.8, revert-184-generic, revert-408-bugfix_394: Remove circular `toList` definition. (446e295)

git at git.haskell.org git at git.haskell.org
Mon Apr 17 21:36:39 UTC 2017


Repository : ssh://git@git.haskell.org/containers

On branches: changelog-foldtree,cleaned_bugfix394,master,merge-doc-target,merge-fixes-5.9,merge-restrict-fix-5.8,revert-184-generic,revert-408-bugfix_394
Link       : http://git.haskell.org/packages/containers.git/commitdiff/446e295ee0db08bb10f6e5dca6f930669b565ffc

>---------------------------------------------------------------

commit 446e295ee0db08bb10f6e5dca6f930669b565ffc
Author: Milan Straka <fox at ucw.cz>
Date:   Tue Dec 16 11:11:07 2014 +0100

    Remove circular `toList` definition.
    
    When writing this, I assumed we have explicit `toList` as we have in
    other containers. We do not have `toList`, and even if we did, the code
    would not compile, as the two `toList`s (ours and `Foldable`) would
    collide.


>---------------------------------------------------------------

446e295ee0db08bb10f6e5dca6f930669b565ffc
 Data/Sequence.hs | 2 --
 1 file changed, 2 deletions(-)

diff --git a/Data/Sequence.hs b/Data/Sequence.hs
index 800ec46..b540978 100644
--- a/Data/Sequence.hs
+++ b/Data/Sequence.hs
@@ -247,8 +247,6 @@ instance Foldable Seq where
     {-# INLINE length #-}
     null   = null
     {-# INLINE null #-}
-    toList   = toList
-    {-# INLINE toList #-}
 #endif
 
 instance Traversable Seq where



More information about the ghc-commits mailing list