[commit: ghc] master: base: Run num009 with -msse2 on i386 (e5e07be)

git at git.haskell.org git at git.haskell.org
Thu Apr 6 21:44:38 UTC 2017


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/e5e07be2df1a0d6f1cb47e9d301053445020589c/ghc

>---------------------------------------------------------------

commit e5e07be2df1a0d6f1cb47e9d301053445020589c
Author: Ben Gamari <ben at smart-cactus.org>
Date:   Thu Apr 6 17:14:47 2017 -0400

    base: Run num009 with -msse2 on i386
    
    x87's transcendental instructions are terribly imprecise and fail this test.
    Moreover, we really ouch to enable -mse2 on i386 by default as it is nearly
    universally supported at this point. See #13540.


>---------------------------------------------------------------

e5e07be2df1a0d6f1cb47e9d301053445020589c
 libraries/base/tests/Numeric/all.T | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/libraries/base/tests/Numeric/all.T b/libraries/base/tests/Numeric/all.T
index 36b2d6f..a0a9d68 100644
--- a/libraries/base/tests/Numeric/all.T
+++ b/libraries/base/tests/Numeric/all.T
@@ -6,6 +6,12 @@ test('num005', normal, compile_and_run, [''])
 test('num006', normal, compile_and_run, [''])
 test('num007', normal, compile_and_run, [''])
 test('num008', normal, compile_and_run, [''])
+
+# On i386, we need -msse2 to get reliable floating point results
+if config.arch == 'i386':
+    opts = '-msse2'
+else:
+    opts = ''
 test('num009', [ when(fast(), skip)
                , when(platform('i386-apple-darwin'), expect_broken(2370))
                , when(opsys('mingw32'), omit_ways(['ghci'])) ],
@@ -14,7 +20,7 @@ test('num009', [ when(fast(), skip)
                # serious, since the results for lower numbers are all fine.
                # We also get another set of results for 1e02 with GHCi, so
                # I'm skipping that way altogether.
-             compile_and_run, [''])
+             compile_and_run, [opts])
 test('num010',
      when(platform('i386-apple-darwin'), expect_broken_for(7043, 'ghci')),
      compile_and_run,



More information about the ghc-commits mailing list