[commit: ghc] ghc-8.2: Remove Core Lint pass on occurrence analysis output (#13220) (52d14ba)

git at git.haskell.org git at git.haskell.org
Sat Apr 1 14:56:35 UTC 2017


Repository : ssh://git@git.haskell.org/ghc

On branch  : ghc-8.2
Link       : http://ghc.haskell.org/trac/ghc/changeset/52d14ba3a0bafafee5620091a3c22717a883a2d7/ghc

>---------------------------------------------------------------

commit 52d14ba3a0bafafee5620091a3c22717a883a2d7
Author: Reid Barton <rwbarton at gmail.com>
Date:   Fri Mar 31 22:48:14 2017 -0400

    Remove Core Lint pass on occurrence analysis output (#13220)
    
    It was expensive, as the simplifier runs for many iterations,
    and probably not very useful.
    
    Test Plan: harbormaster
    
    Reviewers: austin, bgamari, dfeuer
    
    Reviewed By: dfeuer
    
    Subscribers: dfeuer, thomie
    
    Differential Revision: https://phabricator.haskell.org/D3391
    
    (cherry picked from commit 71916e1c018dded2e68d6769a2dbb8777da12664)


>---------------------------------------------------------------

52d14ba3a0bafafee5620091a3c22717a883a2d7
 compiler/simplCore/SimplCore.hs     |  1 -
 testsuite/tests/deriving/perf/all.T | 12 +++++-------
 2 files changed, 5 insertions(+), 8 deletions(-)

diff --git a/compiler/simplCore/SimplCore.hs b/compiler/simplCore/SimplCore.hs
index 34f49ad..cd57705 100644
--- a/compiler/simplCore/SimplCore.hs
+++ b/compiler/simplCore/SimplCore.hs
@@ -738,7 +738,6 @@ simplifyPgmIO pass@(CoreDoSimplify max_iterations mode)
                } ;
            Err.dumpIfSet_dyn dflags Opt_D_dump_occur_anal "Occurrence analysis"
                      (pprCoreBindings tagged_binds);
-           lintPassResult hsc_env CoreOccurAnal tagged_binds;
 
                 -- Get any new rules, and extend the rule base
                 -- See Note [Overall plumbing for rules] in Rules.hs
diff --git a/testsuite/tests/deriving/perf/all.T b/testsuite/tests/deriving/perf/all.T
index 4d88bc9..a711a50 100644
--- a/testsuite/tests/deriving/perf/all.T
+++ b/testsuite/tests/deriving/perf/all.T
@@ -1,13 +1,11 @@
 test('T10858',
      [compiler_stats_num_field('bytes allocated',
-          [(platform('x86_64-unknown-mingw32'), 272402736, 8),
-          # 2017-02-19  272402736  (x64/Windows) - unknown
-
-          (wordsize(64), 275357824, 8) ]),
-          # Initial:    476296112
+          [(wordsize(64), 241242968, 8) ]),
+          # Initial:    222312440
           # 2016-12-19  247768192  Join points (#19288)
-          # 2016-02-12  304094944  Type-indexed Typeable
-          # 2016-02-25  275357824  Early inline patch
+          # 2017-02-12  304094944  Type-indexed Typeable
+          # 2017-02-25  275357824  Early inline patch
+          # 2017-03-28  241242968  Run Core Lint less
       only_ways(['normal'])],
      compile,
      ['-O'])



More information about the ghc-commits mailing list