[commit: ghc] master: Be less picky about reporing inaccessible code (03541cb)
git at git.haskell.org
git at git.haskell.org
Mon Sep 12 15:21:12 UTC 2016
Repository : ssh://git@git.haskell.org/ghc
On branch : master
Link : http://ghc.haskell.org/trac/ghc/changeset/03541cbae50f0d1cdf99120ab88698f29a278159/ghc
>---------------------------------------------------------------
commit 03541cbae50f0d1cdf99120ab88698f29a278159
Author: Simon Peyton Jones <simonpj at microsoft.com>
Date: Fri Sep 9 17:42:42 2016 +0100
Be less picky about reporing inaccessible code
Triggered by the discussion on Trac #12466, this patch
makes GHC less aggressive about reporting an error when
there are insoluble Givens.
Being so agressive was making some libraries fail to
compile, and is arguably wrong in at least some cases.
See the discussion on the ticket.
Several test now pass when they failed before; see
the files-modified list for this patch.
>---------------------------------------------------------------
03541cbae50f0d1cdf99120ab88698f29a278159
compiler/typecheck/TcErrors.hs | 94 +++++++++++++++++-----
compiler/typecheck/TcSMonad.hs | 14 ++--
compiler/typecheck/TcSimplify.hs | 2 +-
testsuite/tests/ghci/scripts/Defer02.script | 3 +
testsuite/tests/ghci/scripts/Defer02.stderr | 37 +++------
testsuite/tests/typecheck/should_compile/T12466.hs | 9 +++
.../tests/typecheck/should_compile/T12466a.hs | 26 ++++++
testsuite/tests/typecheck/should_compile/all.T | 2 +
.../tests/typecheck/should_fail/FDsFromGivens.hs | 1 +
.../typecheck/should_fail/FDsFromGivens.stderr | 19 -----
testsuite/tests/typecheck/should_fail/T10715.hs | 6 ++
.../tests/typecheck/should_fail/T10715.stderr | 13 ---
testsuite/tests/typecheck/should_fail/T5236.hs | 3 +
testsuite/tests/typecheck/should_fail/T5236.stderr | 15 ----
testsuite/tests/typecheck/should_fail/T8392a.hs | 4 +-
.../tests/typecheck/should_fail/T8392a.stderr | 9 ---
testsuite/tests/typecheck/should_fail/all.T | 8 +-
testsuite/tests/typecheck/should_run/Defer01.hs | 1 +
18 files changed, 151 insertions(+), 115 deletions(-)
Diff suppressed because of size. To see it, use:
git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 03541cbae50f0d1cdf99120ab88698f29a278159
More information about the ghc-commits
mailing list