[commit: ghc] master: Derive the Generic instance in perf/compiler/T5642 (34010db)
git at git.haskell.org
git at git.haskell.org
Mon Sep 5 19:48:47 UTC 2016
Repository : ssh://git@git.haskell.org/ghc
On branch : master
Link : http://ghc.haskell.org/trac/ghc/changeset/34010dbe77ac405da6c671c3feb3573d0d025379/ghc
>---------------------------------------------------------------
commit 34010dbe77ac405da6c671c3feb3573d0d025379
Author: Ryan Scott <ryan.gl.scott at gmail.com>
Date: Mon Sep 5 15:45:38 2016 -0400
Derive the Generic instance in perf/compiler/T5642
Summary:
For some inexplicable reason, the `Generic` instance in
`perf/compiler/T5642` is written out entirely by hand. This is not only
strange, since Trac #5642 is about derived `Generic` instances, but it also
annoying to maintain, since it requires manually changing a bunch of code
whenever the algorithm behind `deriving Generic` changes. (See D2304 for a
recent example of this.)
It seems more sensible to just derive the `Generic` instance. It shifts the
goalposts of what allocations we're measuring a bit, since we no longer have
to parse a large amount of code (and as a knock-on effect, the allocations go
down a bit). But I think this program is morally equivalent to what we were
benchmarking before, so it's not too unreasonable to change.
Test Plan: make test TEST=T5642
Reviewers: austin, thomie, bgamari
Reviewed By: bgamari
Differential Revision: https://phabricator.haskell.org/D2511
GHC Trac Issues: #5642
>---------------------------------------------------------------
34010dbe77ac405da6c671c3feb3573d0d025379
testsuite/tests/perf/compiler/T5642.hs | 875 +--------------------------------
testsuite/tests/perf/compiler/all.T | 3 +-
2 files changed, 4 insertions(+), 874 deletions(-)
Diff suppressed because of size. To see it, use:
git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 34010dbe77ac405da6c671c3feb3573d0d025379
More information about the ghc-commits
mailing list