[commit: ghc] master: testsuite/driver: Allow threading on Windows (2864ad7)

git at git.haskell.org git at git.haskell.org
Mon Oct 17 19:02:47 UTC 2016


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/2864ad79ab44f5ca039c30dc3dec816c77dd5cfa/ghc

>---------------------------------------------------------------

commit 2864ad79ab44f5ca039c30dc3dec816c77dd5cfa
Author: Ben Gamari <bgamari.foss at gmail.com>
Date:   Sun Oct 16 20:49:57 2016 -0400

    testsuite/driver: Allow threading on Windows
    
    It seems that threading now works fine. The only caveat here is that it
    makes some race conditions more likely (e.g. #12554), although these
    also appear to affect single-threaded runs.
    
    Test Plan: Validate on Windows
    
    Reviewers: austin, Phyx
    
    Subscribers: thomie
    
    Differential Revision: https://phabricator.haskell.org/D2600
    
    GHC Trac Issues: #10510


>---------------------------------------------------------------

2864ad79ab44f5ca039c30dc3dec816c77dd5cfa
 testsuite/driver/runtests.py | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/testsuite/driver/runtests.py b/testsuite/driver/runtests.py
index abbf3c8..f36725e 100644
--- a/testsuite/driver/runtests.py
+++ b/testsuite/driver/runtests.py
@@ -139,9 +139,6 @@ if config.use_threads == 1:
         print("Warning: Ignoring request to use threads as python version is 2.7.2")
         print("See http://bugs.python.org/issue13817 for details.")
         config.use_threads = 0
-    if windows: # See Trac ticket #10510.
-        print("Warning: Ignoring request to use threads as running on Windows")
-        config.use_threads = 0
 
 config.cygwin = False
 config.msys = False



More information about the ghc-commits mailing list