[commit: ghc] wip/ttypeable: Clarify comments (082104d)

git at git.haskell.org git at git.haskell.org
Sat Oct 1 21:35:47 UTC 2016


Repository : ssh://git@git.haskell.org/ghc

On branch  : wip/ttypeable
Link       : http://ghc.haskell.org/trac/ghc/changeset/082104d03ca025e85bfeb67f507d06429b04bbc8/ghc

>---------------------------------------------------------------

commit 082104d03ca025e85bfeb67f507d06429b04bbc8
Author: Ben Gamari <ben at smart-cactus.org>
Date:   Sun Jul 17 22:02:55 2016 +0200

    Clarify comments


>---------------------------------------------------------------

082104d03ca025e85bfeb67f507d06429b04bbc8
 compiler/prelude/TysPrim.hs      | 7 ++++---
 compiler/typecheck/TcTypeable.hs | 4 ++--
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/compiler/prelude/TysPrim.hs b/compiler/prelude/TysPrim.hs
index f5c80ca..f6808da 100644
--- a/compiler/prelude/TysPrim.hs
+++ b/compiler/prelude/TysPrim.hs
@@ -160,10 +160,11 @@ primTyCons
     ]
 
 -- | The names of the 'TyCon's which we define 'Typeable' bindings for
--- explicitly in "Data.Typeable.Internal"
--- and should not generate bindings for in "GHC.Types".
+-- explicitly in "Data.Typeable.Internal" and should not generate representation
+-- bindings for in "GHC.Types".
 --
--- See Note [Mutually recursive representations of primitive types]
+-- See Note [Mutually recursive representations of primitive types] in
+-- "Data.Typeable.Internal" and Note [Grand plan for Typeable] in "TcTypeable".
 primTypeableTyCons :: NameEnv TyConRepName
 primTypeableTyCons = mkNameEnv
     [ (tYPETyConName, trTYPEName)
diff --git a/compiler/typecheck/TcTypeable.hs b/compiler/typecheck/TcTypeable.hs
index 061d22f..0502f51 100644
--- a/compiler/typecheck/TcTypeable.hs
+++ b/compiler/typecheck/TcTypeable.hs
@@ -167,9 +167,9 @@ mkTypeableTyConBinds tycons
        ; gbl_env <- tcExtendGlobalValEnv tycon_rep_ids getGblEnv
        ; return (gbl_env `addTypecheckedBinds` tc_binds) }
 
--- | Generate bindings for the type representation of a wired-in TyCon defined
+-- | Generate bindings for the type representation of a wired-in 'TyCon's defined
 -- by the virtual "GHC.Prim" module. This is where we inject the representation
--- bindings for primitive types into "GHC.Types"
+-- bindings for these primitive types into "GHC.Types"
 --
 -- See Note [Grand plan for Typeable] in this module.
 mkPrimTypeableBinds :: TcM TcGblEnv



More information about the ghc-commits mailing list