[commit: ghc] master: Kill Type pretty-printer (6c0f10f)
git at git.haskell.org
git at git.haskell.org
Sun Nov 13 22:25:29 UTC 2016
Repository : ssh://git@git.haskell.org/ghc
On branch : master
Link : http://ghc.haskell.org/trac/ghc/changeset/6c0f10fac767c49b65ed71e8eb8e78ca4f9062d5/ghc
>---------------------------------------------------------------
commit 6c0f10fac767c49b65ed71e8eb8e78ca4f9062d5
Author: Ben Gamari <bgamari.foss at gmail.com>
Date: Sun Nov 13 16:17:37 2016 -0500
Kill Type pretty-printer
Here we consolidate the pretty-printing logic for types in IfaceType. We
need IfaceType regardless and the printer for Type can be implemented in
terms of that for IfaceType. See #11660.
Note that this is very much a work-in-progress. Namely I still have yet
to ponder how to ease the hs-boot file situation, still need to rip out
more dead code, need to move some of the special cases for, e.g., `*` to
the IfaceType printer, and need to get it to validate. That being said,
it comes close to validating as-is.
Test Plan: Validate
Reviewers: goldfire, austin
Subscribers: goldfire, thomie, simonpj
Differential Revision: https://phabricator.haskell.org/D2528
GHC Trac Issues: #11660
>---------------------------------------------------------------
6c0f10fac767c49b65ed71e8eb8e78ca4f9062d5
compiler/basicTypes/BasicTypes.hs | 44 ++
compiler/coreSyn/CoreLint.hs | 2 +-
compiler/coreSyn/PprCore.hs | 2 +-
compiler/ghc.cabal.in | 1 +
compiler/ghc.mk | 1 +
compiler/iface/IfaceSyn.hs | 9 +-
compiler/iface/IfaceType.hs | 731 +++++++++++++--------
compiler/iface/IfaceType.hs-boot | 36 +
compiler/iface/MkIface.hs | 223 +------
compiler/iface/TcIface.hs | 18 +-
compiler/iface/ToIface.hs | 497 ++++++++++++++
compiler/iface/ToIface.hs-boot | 15 +
compiler/main/GHC.hs | 2 +-
compiler/prelude/TysWiredIn.hs | 7 +-
compiler/prelude/TysWiredIn.hs-boot | 2 +-
compiler/typecheck/TcDeriv.hs | 5 +-
compiler/typecheck/TcDerivInfer.hs | 2 +-
compiler/typecheck/TcErrors.hs | 2 +-
compiler/typecheck/TcExpr.hs | 2 +-
compiler/typecheck/TcHsType.hs | 2 +-
compiler/typecheck/TcInteract.hs | 2 +-
compiler/typecheck/TcMType.hs | 2 +-
compiler/typecheck/TcPat.hs | 7 +-
compiler/typecheck/TcRnTypes.hs | 2 +-
compiler/typecheck/TcTyClsDecls.hs | 4 +-
compiler/typecheck/TcValidity.hs | 2 +-
compiler/types/Coercion.hs-boot | 1 +
compiler/types/TyCoRep.hs | 603 ++---------------
compiler/types/TyCoRep.hs-boot | 3 +-
compiler/types/TyCon.hs | 2 +-
compiler/types/Type.hs | 8 +-
compiler/utils/Binary.hs | 8 +
.../tests/deSugar/should_compile/T2431.stderr | 2 +-
.../dependent/should_fail/TypeSkolEscape.stderr | 2 +-
testsuite/tests/ghci/scripts/T11252.stdout | 2 +-
testsuite/tests/ghci/scripts/T2766.stdout | 2 +-
testsuite/tests/ghci/scripts/ghci059.stdout | 2 +-
testsuite/tests/roles/should_compile/T8958.stderr | 6 +-
.../tests/typecheck/should_compile/T10632.stderr | 2 +-
.../typecheck/should_fail/ClassOperator.stderr | 8 +-
.../tests/typecheck/should_fail/IPFail.stderr | 2 +-
.../tests/typecheck/should_fail/T7019a.stderr | 2 +-
testsuite/tests/typecheck/should_fail/T7525.stderr | 16 +-
testsuite/tests/typecheck/should_fail/T8912.stderr | 10 +-
.../tests/typecheck/should_fail/tcfail041.stderr | 10 +-
.../tests/typecheck/should_fail/tcfail130.stderr | 9 +-
.../tests/typecheck/should_fail/tcfail211.stderr | 4 +-
.../tests/typecheck/should_run/tcrun045.stderr | 6 +-
48 files changed, 1200 insertions(+), 1132 deletions(-)
Diff suppressed because of size. To see it, use:
git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 6c0f10fac767c49b65ed71e8eb8e78ca4f9062d5
More information about the ghc-commits
mailing list