[commit: ghc] master: Handle types w/ type variables in signatures inside patterns (DsMeta) (b012120)

git at git.haskell.org git at git.haskell.org
Sat Nov 5 22:09:49 UTC 2016


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/b0121209f8fb47a7cb8fc32e10d8e2c06d4502c2/ghc

>---------------------------------------------------------------

commit b0121209f8fb47a7cb8fc32e10d8e2c06d4502c2
Author: Mikhail Vorozhtsov <mikhail.vorozhtsov at gmail.com>
Date:   Sat Nov 5 22:06:39 2016 +0000

    Handle types w/ type variables in signatures inside patterns (DsMeta)
    
    The comment indicated that scoping of type variables was a large problem
    but Simon fixed it in e21e13fb52b99b14770cc5857df57bbcc9c85102.
    
    Thus, we can implement repP for signatures very easily in the usual way
    now.
    
    Reviewers: goldfire, simonpj, austin, bgamari
    
    Reviewed By: simonpj
    
    Subscribers: mpickering, simonpj, thomie
    
    Differential Revision: https://phabricator.haskell.org/D2490
    
    GHC Trac Issues: #12164


>---------------------------------------------------------------

b0121209f8fb47a7cb8fc32e10d8e2c06d4502c2
 compiler/deSugar/DsMeta.hs                         | 14 +++----
 .../PatternSplice.hs}                              |  3 +-
 testsuite/tests/partial-sigs/should_compile/all.T  |  1 +
 .../ExtraConstraintsWildcardInPatternSplice.hs     |  2 +-
 .../ExtraConstraintsWildcardInPatternSplice.stderr | 13 ++++++-
 testsuite/tests/th/TH_repPatSig.hs                 | 16 ++++----
 testsuite/tests/th/TH_repPatSig.stderr             |  4 --
 .../th/{TH_repPatSig.hs => TH_repPatSigTVar.hs}    |  9 +----
 testsuite/tests/th/TH_repPatSigTVar.stderr         |  8 ++++
 testsuite/tests/th/TH_repPatSig_asserts.hs         | 44 ++++++++++++++++++++++
 testsuite/tests/th/all.T                           |  6 ++-
 11 files changed, 87 insertions(+), 33 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc b0121209f8fb47a7cb8fc32e10d8e2c06d4502c2


More information about the ghc-commits mailing list