[commit: ghc] master: rts: More const correct-ness fixes (33c029d)

git at git.haskell.org git at git.haskell.org
Tue May 17 23:05:06 UTC 2016


Repository : ssh://git@git.haskell.org/ghc

On branch  : master
Link       : http://ghc.haskell.org/trac/ghc/changeset/33c029dd77888ee5f9b1c7ce8884c982e0428adf/ghc

>---------------------------------------------------------------

commit 33c029dd77888ee5f9b1c7ce8884c982e0428adf
Author: Erik de Castro Lopo <erikd at mega-nerd.com>
Date:   Wed May 18 06:33:03 2016 +1000

    rts: More const correct-ness fixes
    
    In addition to more const-correctness fixes this patch fixes an
    infelicity of the previous const-correctness patch (995cf0f356) which
    left `UNTAG_CLOSURE` taking a `const StgClosure` pointer parameter
    but returning a non-const pointer. Here we restore the original type
    signature of `UNTAG_CLOSURE` and add a new function
    `UNTAG_CONST_CLOSURE` which takes and returns a const `StgClosure`
    pointer and uses that wherever possible.
    
    Test Plan: Validate on Linux, OS X and Windows
    
    Reviewers: Phyx, hsyl20, bgamari, austin, simonmar, trofi
    
    Reviewed By: simonmar, trofi
    
    Subscribers: thomie
    
    Differential Revision: https://phabricator.haskell.org/D2231


>---------------------------------------------------------------

33c029dd77888ee5f9b1c7ce8884c982e0428adf
 includes/rts/storage/ClosureMacros.h | 50 ++++++++++++++++++++++++++----------
 includes/rts/storage/InfoTables.h    |  8 +++---
 rts/CheckUnload.c                    |  6 ++---
 rts/Hash.c                           | 10 ++++----
 rts/Hash.h                           |  9 +++++--
 rts/Hpc.c                            |  3 ++-
 rts/Printer.c                        | 49 ++++++++++++++++++-----------------
 rts/Printer.h                        | 16 ++++++------
 rts/ProfHeap.c                       | 18 ++++++-------
 rts/Profiling.c                      |  6 ++---
 rts/RaiseAsync.c                     |  2 +-
 rts/RetainerProfile.c                |  2 +-
 rts/RtsAPI.c                         |  4 +--
 rts/STM.c                            |  2 +-
 rts/Schedule.c                       |  8 +++---
 rts/Stable.c                         |  2 +-
 rts/ThreadPaused.c                   |  2 +-
 rts/sm/Compact.c                     |  9 ++++---
 rts/sm/Sanity.c                      | 21 +++++++--------
 rts/sm/Sanity.h                      |  2 +-
 rts/sm/Scav.c                        | 12 ++++-----
 21 files changed, 138 insertions(+), 103 deletions(-)

Diff suppressed because of size. To see it, use:

    git diff-tree --root --patch-with-stat --no-color --find-copies-harder --ignore-space-at-eol --cc 33c029dd77888ee5f9b1c7ce8884c982e0428adf


More information about the ghc-commits mailing list