[commit: ghc] ghc-8.0: Delete a misleading comment in TyCon (c948a30)

git at git.haskell.org git at git.haskell.org
Wed Mar 23 16:38:13 UTC 2016


Repository : ssh://git@git.haskell.org/ghc

On branch  : ghc-8.0
Link       : http://ghc.haskell.org/trac/ghc/changeset/c948a300225db11edaffda1cdcc2e7653e80f021/ghc

>---------------------------------------------------------------

commit c948a300225db11edaffda1cdcc2e7653e80f021
Author: Bartosz Nitka <niteria at gmail.com>
Date:   Mon Mar 21 03:30:59 2016 -0700

    Delete a misleading comment in TyCon
    
    `Ord` for `TyCon` uses `Uniques` and it's not lexicographic.
    I did some archeology and in
    rGHC6c381e873e222417d9a67aeec77b9555eca7b7a8 the comment was introduced,
    where there was something like `Ord3 Tycon` which *was* lexicographic.
    In rGHC9dd6e1c216993624a2cd74b62ca0f0569c02c26b `Ord3 TyCon` was already
    not lexicographic and `Ord3` got removed.
    
    Test Plan: make someone take a look
    
    Reviewers: hvr, austin, bgamari
    
    Reviewed By: bgamari
    
    Subscribers: thomie, simonmar
    
    Differential Revision: https://phabricator.haskell.org/D2017
    
    (cherry picked from commit 3ade8bc790c74c676f75001373247835d3b23ff5)


>---------------------------------------------------------------

c948a300225db11edaffda1cdcc2e7653e80f021
 compiler/types/TyCon.hs | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/compiler/types/TyCon.hs b/compiler/types/TyCon.hs
index 5d01732..69a9360 100644
--- a/compiler/types/TyCon.hs
+++ b/compiler/types/TyCon.hs
@@ -2027,9 +2027,6 @@ tyConRuntimeRepInfo _                                         = NoRRI
 ************************************************************************
 
 @TyCon at s are compared by comparing their @Unique at s.
-
-The strictness analyser needs @Ord at . It is a lexicographic order with
-the property @(a<=b) || (b<=a)@.
 -}
 
 instance Eq TyCon where



More information about the ghc-commits mailing list